Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: updating regarding template language #1353

Closed
mfranzke opened this issue Sep 15, 2021 · 3 comments
Closed

Documentation: updating regarding template language #1353

mfranzke opened this issue Sep 15, 2021 · 3 comments

Comments

@mfranzke
Copy link
Contributor

mfranzke commented Sep 15, 2021

Expected Behavior

The documentation still mentions a lot of files with the .mustache file ending, and the mustache template language as well.

Actual Behavior

As we've switched to handlebars templates as the successor of mustache, I would expect to only have .hbs instead of .mustache and other mentions of mustache as well.

@jaishankar02
Copy link

I have done some changes can you please tell me whether its right or wrong. screenshot is attached below for your reference
Screenshot 2021-12-23 134151

@mfranzke mfranzke changed the title Documentation: updating regarding templates fileendings Documentation: updating regarding template language Jan 1, 2022
@mfranzke
Copy link
Contributor Author

mfranzke commented Jan 1, 2022

@jaishankar02 thanks a lot for your contribution.

This ticket is mainly about changing the documentation (in /packages/docs) from the previous template language mustache and its file ending to its successor handlebars (and its file ending .hbs).

So it most likely doesn't involve any changes in the other packages or the template files themselves.

I can't clearly identify from the screenshot you've provided, but you've seemed to have duplicated the general template files for header and footer – this isn't necessary, as those are even already in the new handlebars format. So in other words, the documentation in this repository needs to get changed to accommodate the changes that even already happened in the code (base).

@mfranzke
Copy link
Contributor Author

kind of a duplicate to #1239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants