-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting 404 for empty input #770
Labels
Comments
Makes sense — the fix should be quite simple, so marking this as a good first issue. |
Hi, I've sent PR, check pls and if need some changes, I'll update it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
It looks like it is expected behaviour but I don't think we should allow an empty input call from the frontend.
To Reproduce
Don't type anything in the search box and press enter.
It takes you to
https://bundlephobia.com/package
which gives 404.Expected behavior
I believe we should just do nothing when the input is empty.
Let me know if the suggested fix is good and I can make a relevant PR for the same.
The text was updated successfully, but these errors were encountered: