Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle DNSVS Webapi errors #1

Open
robinro opened this issue Nov 21, 2016 · 3 comments
Open

Better handle DNSVS Webapi errors #1

robinro opened this issue Nov 21, 2016 · 3 comments

Comments

@robinro
Copy link
Contributor

robinro commented Nov 21, 2016

Currently exceptions in calls to DNSVS are only reported with minimal output and then dropped. Improve this, by

  • output the API error
  • if exception is fatal, stop execution
@robinro robinro self-assigned this Nov 21, 2016
@robinro
Copy link
Contributor Author

robinro commented Nov 22, 2016

While doing so: reduce code duplication in the webapi section.

@robinro robinro removed their assignment Dec 9, 2016
@martingabelmann
Copy link
Member

Better use https://git.scc.kit.edu/scc-net/netvs/netdb-client-lib directly which will reduce our code base by a lot.
However: requires python3.7 and OpenSuse still runs 3.6 (!!) so waiting might be worth it.

@AlexanderKaschta
Copy link

A small hint from the NETVS team: The netdb-client-lib relies on the net_api_generator, but the netdb-client-lib itself should run on Python 3.6. The generated classes of the net_api_generator however depend on the dataclass feature of Python, which has been introduced in Python 3.7. There is a backport for the dataclass feature for Python 3.6, which can be installed thru PyPI and should just get it running. If there are further questions, we are happy to support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants