Thanks for opening this pull request!

Hello @mman,
You mentioned that you would beta test. Please look at the solution and let me know what you think.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.79%. Comparing base (f1469c6) to head (da99d51).
Report is 13 commits behind head on alpha.

@@            Coverage Diff             @@
##            alpha    #9113      +/-   ##
==========================================
- Coverage   94.13%   93.79%   -0.35%     
==========================================
  Files         186      186              
  Lines       14687    14731      +44     
==========================================
- Hits        13826    13817       -9     
- Misses        861      914      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Thanks a lot @vivekjoshi556, I will take a look first thing next week, now OOO.

Hey @mman. Just wanted to check if you got some time to look at the PR.

@vivekjoshi556 The code looks nice and clean, the tests as well. Will try to deploy to my stage env later today.

Hey @mman Just wanted to check in again.

@mtrezza if you have inputs as well, please let me know.

There is a minor issue with linting I'll fix it in the next push, anything else let me know.

This fix just shifts the problem downwards from 24 hours to 1 minute. Because for a session length of <1 minute, the problem in #8981 persists.

I wonder whether we need such a complex logic for this. If I understand #8981 (comment) correctly, the purpose of this logic is to find a middle ground between:

• extending the session on every request --> con: high DB writes
• ensuring that the session extends before it expires --> con: session would never get extended

Wouldn't it be simpler to extend the session when the remaining session token validity time reached < 50% of the session length?

For example:

• session length 1 year --> session extends if remaining time is < 182 days
• session length 1 day --> session extends if remaining time is < 12 hours
• session length 1 hour --> session extends if remaining time is < 30 mins
• session length 1 minute --> session extends if remaining time is < 30 secs

Pros:

• Simple to document and understand
• This adapts dynamically to the session length, instead of some arbitrary extension trigger times
• It's easy to make this configurable via a new Parse Server option in the future, by letting a developer configure the threshold, e.g. 50% as in examples above.

And could you please document this new behavior in the Parse Server option extendSessionOnUse?

@vivekjoshi556 Just a friendly ping here; if you could simplify the logic and add the functionality description to the option docs (this repo, not the docs repo), then we could go ahead and merge.

So sorry just got a bit swamped with work. Give me some time