Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move code to /src #397

Open
sadortun opened this issue Aug 16, 2021 · 5 comments
Open

Move code to /src #397

sadortun opened this issue Aug 16, 2021 · 5 comments

Comments

@sadortun
Copy link

Hi!

What do you think about moving sources to /src folder ? I think it could make it more clear for new users what's config VS actual code ?

Have a nice day,
Samuel

@dblythy
Copy link
Member

dblythy commented Aug 17, 2021

I don't mind this suggestion, I think it could tidy up folder management. The current setup gives the impression that all these files are needed to create a Parse Server, when in reality it's only a few (which would be contained in /src.

I think that a lot of docs would need to updated inline with this change, just to make sure there's no confusion.

We are also working on a CLI version to generate an example Parse Server, so this way you only receive files that you need (for example, you would only receive ESLint files if you select ESLint in the CLI config)

@sadortun
Copy link
Author

Nice ! So should I open a PR with this first step or we wait for your CLI?

@dblythy
Copy link
Member

dblythy commented Aug 17, 2021

@mtrezza what are your thoughts?

@mtrezza
Copy link
Member

mtrezza commented Aug 17, 2021

Good idea, I think a /src folder is a common practice, and we also use it in the parse-server repo.

I assume that includes the index.js and contents of /cloud? We would have to look into the docs and readme whether changes are necessary, because the concept of /cloud/main.js has been around for years, so there may be references to it.

@sadortun
Copy link
Author

We would have to look into the docs and readme whether changes are necessary

The important would be to make sure to update links that points to theses files to avoid 404. But if we forget a few links that only mention /cloud , it's not a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants