fix: Info panel not showing when some apps miss infoPanel config #2627
Conversation
Thanks for opening this pull request!
|
Uffizzi Ephemeral Environment
|
There was a problem hiding this comment.
The "Show panel" button doesn't appear, when having a second app in dashboard config. Before this PR, a workaround was to add an empty panel "infoPanel": [],, but that doesn't work anymore either. Could you please verify the fix with the following configs:
1 app w/ panel:
{
"apps": [
{
"serverURL": "https://app1.example.com",
"appId": "appId1",
"masterKey": "masterKey",
"appName": "app1",
"infoPanel": [
{
"title": "User Details",
"classes": ["_User"],
"cloudCodeFunction": "user"
}
]
}
]
}
2 apps, 1 w/ panel, 1 w/o panel:
{
"apps": [
{
"serverURL": "https://app1.example.com",
"appId": "appId1",
"masterKey": "masterKey",
"appName": "app1",
"infoPanel": [
{
"title": "User Details",
"classes": ["_User"],
"cloudCodeFunction": "user"
}
]
},
{
"serverURL": "https://app2.example.com",
"appId": "appId2",
"masterKey": "masterKey",
"appName": "app2"
}
]
}
2 apps, 1 w/ panel, 1 w/ empty panel:
{
"apps": [
{
"serverURL": "https://app1.example.com",
"appId": "appId1",
"masterKey": "masterKey",
"appName": "app1",
"infoPanel": [
{
"title": "User Details",
"classes": ["_User"],
"cloudCodeFunction": "user"
}
]
},
{
"serverURL": "https://app2.example.com",
"appId": "appId2",
"masterKey": "masterKey",
"appName": "app2",
"infoPanel": []
}
]
}
2 apps, 2 w/ panel in same class:
{
"apps": [
{
"serverURL": "https://app1.example.com",
"appId": "appId1",
"masterKey": "masterKey",
"appName": "app1",
"infoPanel": [
{
"title": "User Details",
"classes": ["_User"],
"cloudCodeFunction": "user"
}
]
},
{
"serverURL": "https://app2.example.com",
"appId": "appId2",
"masterKey": "masterKey",
"appName": "app2",
"infoPanel": [
{
"title": "User Details",
"classes": ["_User"],
"cloudCodeFunction": "user"
}
]
}
]
}
2 apps, 2 w/ panel in different classes:
{
"apps": [
{
"serverURL": "https://app1.example.com",
"appId": "appId1",
"masterKey": "masterKey",
"appName": "app1",
"infoPanel": [
{
"title": "User Details",
"classes": ["_User"],
"cloudCodeFunction": "user"
}
]
},
{
"serverURL": "https://app2.example.com",
"appId": "appId2",
"masterKey": "masterKey",
"appName": "app2",
"infoPanel": [
{
"title": "Installation Details",
"classes": ["_Installation"],
"cloudCodeFunction": "installation"
}
]
}
]
}
|
@mtrezza, it’s working locally for me, but I'm not sure why it’s not working for you. I’ve pushed everything. Screen.Recording.2024-11-07.005039.mp4 |
|
Did you try out all the configs from my previous comment? Some do not seem to work. |
Yes @mtrezza , I tried all the configurations, and they seem to be working on my end. Could you let me know which specific ones aren’t working for you? |
New Pull Request Checklist
Issue Description
Closes: #2623
Approach
TODOs before merging