Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ArrayBuffer encoding #21

Open
apowers313 opened this issue Feb 27, 2017 · 0 comments
Open

Handle ArrayBuffer encoding #21

apowers313 opened this issue Feb 27, 2017 · 0 comments

Comments

@apowers313
Copy link

Currently if an attribute in a JSON object being encoded is of type ArrayBuffer, it is silently ignored. It would be nice if somewhere around line 158, encode detected that the type was ArrayBuffer and promoted it to a Uint8Array to be encoded properly.

The same request may apply for handling other TypedArrays and DataViews.
@aaronhuggins aaronhuggins mentioned this issue Sep 3, 2020
Merged
aaronhuggins referenced this issue in aaronhuggins/cbor-redux Sep 3, 2020
@aaronhuggins
Merge pull request #5 from aaronhuggins/typescript-rewrite
adb690b 
Typescript rewrite

Rewritten to TypeScript for Deno support and Node typescript definitions, now as a ponyfill.
Added tests for more scenarios and to bring coverage up.
Modernized syntax and tests.
Added code quality and coverage analysis.
Removed default polyfill behavior and added back as an optional module.

Addresses the following issues:
paroga#27
paroga#24
paroga#21
paroga#13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apowers313