-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish release script is broken #1618
Comments
oh I forgot we even had such a script and just copy the command in the RELEASING doc. We def don't need a bunch of the ocmplexity there (ie cargo now waits for the crate itself anyway) so I'd be game for removing or just simplifying it! (perhaps it could handle using |
Unfortunately ➜ core (master) ✗ cargo hack publish --allow-dirty --remove-dev-deps --dry-run
info: running `cargo publish --allow-dirty --dry-run` on subxt-core (1/1)
error: failed to load manifest for workspace member `/home/niklasad1/Github/subxt/testing/integration-tests`
referenced by workspace at `/home/niklasad1/Github/subxt/Cargo.toml`
Caused by:
failed to parse manifest at `/home/niklasad1/Github/subxt/testing/integration-tests/Cargo.toml`
Caused by:
feature `unstable-light-client` includes `subxt/unstable-light-client`, but `subxt` is not a dependency |
I believe it would be easier to copy paste the release command from the RELEASING doc. Then, we won't have to maintain anymore the release script, just the doc command. What do you guys think? |
Yes, but there is the caveat with the cyclic dependencies for With that said, I'm in favor of removing it, since the what we have in the RELEASE doc is sufficient but we could explain the core stuff... |
The publish release script: https://github.com/paritytech/subxt/blob/master/scripts/publish.sh is both broken and outdated.
core
,light-client
andsigner
core
has the signer as a dev-dependency it needs to be removed otherwise it can't be released.Alternatively, just remove it
The text was updated successfully, but these errors were encountered: