Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pallets/approved-referenda endpoint #1476

Open
Imod7 opened this issue Aug 15, 2024 · 0 comments
Open

Add pallets/approved-referenda endpoint #1476

Imod7 opened this issue Aug 15, 2024 · 0 comments
Assignees
Labels
C0 - Relay Related to the Relay chain I8 - Enhancement Additional feature request P5 - Sometime Soon Worth doing soon

Comments

@Imod7
Copy link
Contributor

Imod7 commented Aug 15, 2024

Description

Related to #1431

Add a new endpoint pallets/approved-referenda to retrieve information of scheduled Approved referenda of (potential) runtime upgrades and similar referenda created for root and whitelisted caller tracks (track 0 and 1 respectively) of OpenGov.

Issue that it solves

With the existing endpoint pallets/on-going-referenda (#1471) we only show the referenda that are in status OnGoing so as soon as a Referendum gets Approved we stopped showing it. However from the time it gets Approved until its Enacted there is still quite a lot of block time.

Example

  • 373 Upgrade Kusama v1.2.0 -> enactment at block #22790000 - code Updated event
    - block 22691622 : last block when ref373 is in status OnGoing -> so it is still shown by the pallets/on-going-referenda endpoint
    - block 22691623 : ref373 gets Approved -> so we stop showing it in the endpoint's response
    - block 22790000 : ref373 gets enacted

so during approx 98.000 blocks there is still a Runtime Upgrade coming but we do not show it.

Possible Issue
Someone checks the endpoint after the referenda of the runtime upgrade was approved so they miss it.

Additional Information

Idea from @IkerAlus
Add a small section in the endpoints doc for Governance, and consider including other additions in the future, such as additional tracks and other relevant content.

Thanks & Credits

@IkerAlus for all the valuable feedback on the idea of showing also approved referenda. Credits to him for suggesting a whole separate endpoint.

@Imod7 Imod7 added I8 - Enhancement Additional feature request P5 - Sometime Soon Worth doing soon C0 - Relay Related to the Relay chain labels Aug 15, 2024
@Imod7 Imod7 self-assigned this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C0 - Relay Related to the Relay chain I8 - Enhancement Additional feature request P5 - Sometime Soon Worth doing soon
Projects
None yet
Development

No branches or pull requests

1 participant