backport/rpc-v2: Refactor archive_storage method into subscription (#6483)
#6710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
added
the
A3-backport
lexnv
changed the title
archive_storage method into subscription (#6483)archive_storage method into subscription (#6483)
niklasad1
previously approved these changes
Nov 29, 2024
EgorPopelyaev
previously approved these changes
Dec 3, 2024
EgorPopelyaev
dismissed stale reviews from niklasad1 and themself
The base branch was changed.
niklasad1
previously approved these changes
Dec 3, 2024
This PR adapts the `archive_storage` implementation from a method to a subscription. This keeps the archive APIs uniform and consistent. Builds on: #5997 cc @paritytech/subxt-team --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: James Wilson <[email protected]>
lexnv
force-pushed
the
lexnv/backport-storage
branch
from
53b0729 to
1411929
Compare
|
@EgorPopelyaev should be ready for another review, force pushed the cherry-pick 🙏 |
|
This pull request is amending an existing release. Please proceed with extreme caution,
Emergency Bypass
If you really need to bypass this check: add |
niklasad1
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports: #6483
Builds on top of the backport: #6709
cc @paritytech/subxt-team