Skip to content

Commit

Permalink
Update prdoc/pr_6643.prdoc
Browse files Browse the repository at this point in the history
Co-authored-by: Adrian Catangiu <[email protected]>
  • Loading branch information
franciscoaguirre and acatangiu authored Nov 29, 2024
1 parent 7d777cf commit 899b995
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions prdoc/pr_6643.prdoc
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ doc:
- audience: Runtime Dev
description: |-
Removing the `require_weight_at_most` parameter in V5 Transact introduced a problem when converting a message from V5 to V4 to send to chains that didn't upgrade yet. The local chain doesn't know how to decode call for remote chain so it can't automatically populate `require_weight_at_most` required by V4 Transact.

To fix this, I added back the weight in the form of an `Option<Weight>` called `fallback_max_weight`. This can be set to `None` if you don't intend to deal with a chain that hasn't upgraded yet. If you set it to `Some(_)`, the behaviour is the same. The plan is to totally remove this in V6 since there will be a good conversion path from V6 to V5.
To fix this, XCM v5 Transact now also takes a `fallback_max_weight: Option<Weight>` parameter. This can be set to `None` if the instruction is not meant to be sent to chains running XCM versions lower than V5. If set to `Some(w)`, a subsequent conversion to V4 will result in `Transact { require_weight_at_most: w, .. }`. The plan is to remove this workaround in V6 since there will be a good conversion path from V6 to V5.
crates:
- name: snowbridge-router-primitives
bump: major
Expand Down

0 comments on commit 899b995

Please sign in to comment.