Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when validating prdoc in a PR that introduce a new crate #42

Open
gui1117 opened this issue Dec 2, 2024 · 0 comments
Open

Error when validating prdoc in a PR that introduce a new crate #42

gui1117 opened this issue Dec 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@gui1117
Copy link

gui1117 commented Dec 2, 2024

In this PR paritytech/polkadot-sdk#6140 I introduce a new crate in the workspace.

the semver check using parity publish is failing with:

 validating prdocs...
checking file changes...
checking dep changes...
Error: no dep

Stack backtrace:
   0: parity_publish::prdoc::get_dep
   1: parity_publish::prdoc::manifest_deps_changed
   2: parity_publish::prdoc::handle_prdoc
   3: parity_publish::main::{{closure}}
   4: tokio::runtime::park::CachedParkThread::block_on
   5: tokio::runtime::context::runtime::enter_runtime
   6: tokio::runtime::runtime::Runtime::block_on
   7: parity_publish::main
   8: std::sys::backtrace::__rust_begin_short_backtrace
   9: std::rt::lang_start::{{closure}}
  10: std::rt::lang_start_internal
  11: main
  12: __libc_start_main
  13: _start

https://github.com/paritytech/polkadot-sdk/actions/runs/12111543947/job/33763614902?pr=6140

@gui1117 gui1117 added the enhancement New feature or request label Dec 2, 2024
@gui1117 gui1117 changed the title Show better error for when new crate is put in prdoc crates section. Error when validating prdoc in a PR that introduce a new crate Dec 2, 2024
@gui1117 gui1117 added bug Something isn't working and removed enhancement New feature or request labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant