-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better name for workflow objects #236
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think that navigating and debugging the code could be made easier if there were different filenames for the workflow and the submission (for instance
classifier.py
is both a workflow module and most of the time the module of the submission) as well as different names for the workflow objects and the submission objects.For instance, for the classifier workflow the name used for the workflow object
Classifier
withtrain_submission
andtest_submission
methods is the same as theClassifier
object withfit
andpredict
of the submission. This is of course even more relevant when we use workflows such asFeatureExtratorClassifier
where we have a line withA solution would be to use
classifier_workflow.py
instead ofclassifier.py
andClassifierWorkflow
for the workflow object and keepClassifer
for the submission. The former might be a bit redundant and less justified if we consider only the rampwf codebase alone without a kit but the latter seems relevant as the classifier workflow objectClassifier
is called inFeatureExtractorClassifier
and theClassifier
object of the submission is called in theClassifier
workflow. We could instead haveThe text was updated successfully, but these errors were encountered: