Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : #58748 BUG: eval fails for ExtensionArray #58793

Merged
merged 10 commits into from
Jun 12, 2024
Merged

Fix : #58748 BUG: eval fails for ExtensionArray #58793

merged 10 commits into from
Jun 12, 2024
+12 −5

Conversation

SiddheshBangar
Copy link
Contributor

mutricyl
mutricyl reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@mutricyl mutricyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you consider adding a test ? maybe based on the example I provided ?
it may be located in pandas\tests\extension\test_datetime.py

pandas/core/computation/ops.py Outdated Show resolved Hide resolved
@SiddheshBangar
Copy link
Contributor Author

Hey @mutricyl thanks for mentioning it, I have worked on it and did the necessary changes. Let me know if any other changes need to be made I will work on it. Thanks

@rhshadrach rhshadrach added Bug expressions pd.eval, query labels May 21, 2024
@SiddheshBangar
Copy link
Contributor Author

Thanks @rhshadrach @mutricyl I will work on this and update the PR as well

@SiddheshBangar
Copy link
Contributor Author

Although, I tried making necessary changes, and I run the pre-commits as well didn't faced any issues in it but while doing here some checks are failing any guidance how can I move forward to this?

@mutricyl mutricyl mentioned this pull request May 24, 2024
Open
@SiddheshBangar
Copy link
Contributor Author

@rhshadrach @mutricyl pushed one more PR, I fixed the issues, sorry from my end once again. Let me know if this works perfectly. Once again thanks for the help.

@SiddheshBangar
Copy link
Contributor Author

Hey @rhshadrach @mutricyl just a follow up message that could you check the PR that I have pushed a while ago I hope this works for your guys do check and let me know if any more changes are required to be done from my end as well. Thanks!

@rhshadrach rhshadrach added this to the 3.0 milestone Jun 3, 2024
rhshadrach
rhshadrach requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - can you add a line in the whatsnew for 3.0 in the Other section. That section mentions not to use it, but I believe this case to be appropriate.

@SiddheshBangar
Copy link
Contributor Author

@rhshadrach updated the docs and committed the changes do check the PR and let me know if this works, Thanks!

rhshadrach
rhshadrach approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added the ExtensionArray Extending pandas with custom dtypes or arrays. label Jun 12, 2024
@rhshadrach rhshadrach merged commit de5d732 into pandas-dev:main Jun 12, 2024
51 checks passed
@rhshadrach
Copy link
Member

Thanks @SiddheshBangar

@SiddheshBangar
Copy link
Contributor Author

Welcome, thanks for helping and the guidance @rhshadrach, @mutricyl

@SiddheshBangar SiddheshBangar deleted the Fix#58748 branch June 13, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewgsavage andrewgsavage andrewgsavage left review comments

@mutricyl mutricyl mutricyl left review comments

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Bug expressions pd.eval, query ExtensionArray Extending pandas with custom dtypes or arrays.
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

BUG: eval fails for ExtensionArray
4 participants
@SiddheshBangar @rhshadrach @andrewgsavage @mutricyl