Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to date-fns v3 #6744

Open
justinbhopper opened this issue Mar 15, 2024 · 2 comments
Open

Upgrade to date-fns v3 #6744

justinbhopper opened this issue Mar 15, 2024 · 2 comments

Comments

@justinbhopper
Copy link
Contributor

Feature request

BlueprintJS is currently using date-fns v2, which had a big issue of polluting the global namespace with their TypeScript definitions. This causes conflicts with anyone consuming date-fns v2 or any library including it as a dependency (e.g. BlueprintJS). I can give examples of side effects if that helps decide priority.

This pollution is unavoidable. It's impossible to tell TypeScript to ignore their definitions.

date-fns fixed this in v3 (3 months ago). It would be great if BlueprintJS could upgrade to latest!

@adidahiya
Copy link
Contributor

adidahiya commented Mar 17, 2024

Blueprint could not upgrade to date-fns v3 for the past few months because date-fns-tz was incompatible with v3. However, it looks like a PR to bump to v3 in date-fns-tz just merged very recently: marnusw/date-fns-tz#265

So it should be possible to upgrade Blueprint to date-fns v3 after date-fns-tz releases its next stable major version.

@ericjeney
Copy link
Contributor

date-fns-tz v3.0.0 has released: https://github.com/marnusw/date-fns-tz/releases/tag/v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants