Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5-beta.1 breaks when using bootstrap5 #187

Open
leonardolb opened this issue Mar 17, 2024 · 4 comments
Open

0.5-beta.1 breaks when using bootstrap5 #187

leonardolb opened this issue Mar 17, 2024 · 4 comments

Comments

@leonardolb
Copy link

leonardolb commented Mar 17, 2024

Hi!

After updating to 0.5-beta.1 all of my views using bootstrap5 stopped working.

You can reproduce this issue with same data and files i've posted here.

#171 (comment)

Body isn't rendered, just header and footer.

@leonardolb
Copy link
Author

@NigelCunningham hi!
Could you check this issue? Is there anything wrong i did?

@nbyloff
Copy link

nbyloff commented Mar 29, 2024

@leonardolb same issue with bs5

edit: I am getting a console error and it stops rendering after my TOC. This issue wasn't present in 0.5.0-beta.0. (having a different issue with beta.0).

console error:

Uncaught (in promise) TypeError: source is undefined

relevant pagedjs code:


addOverflowNodes(dest, source) {
			// Since we are modifying source as we go, we need to remember what
			Array.from(source.childNodes).forEach((item) => {
				if (isText(item)) {
					// If we get to a text node, we assume for now an earlier element
					// would have prevented duplication.
					dest.append(item);
				} else {
					let match = findElement(item, dest);
					if (match) {
						this.addOverflowNodes(match, item);
					} else {
						dest.appendChild(item);
					}
				}
			});
		}

@leonardolb
Copy link
Author

Hi @nbyloff Did you solve your issue?

I have some issues with html print inside tables also =(

@nbyloff
Copy link

nbyloff commented May 1, 2024

@leonardolb no I have not. I saw @NigelCunningham updated here he has fixes in the pipeline. While this and a couple other issues haven't been directly commented on, I will test the new beta version when available. I think at one point he made a comment his next update should address several issues he found.

I will report back here when there's a new beta whether it works for me or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants