-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contract_requiring_verification_published webhook - should it trigger on first publication #574
Comments
Do any versions exist on the main branch for the provider at this stage? |
no provider build in this scenario has never run, |
Yup, the reason it doesn't trigger is that it doesn't know the version to trigger for because there are no version numbers in the database. We've had a discussion about using |
expectation is from this note https://docs.pact.io/pact_nirvana/notes_1
however it doesn't suggest that the provider in that scenario has never run. ahh, interesting thanks for that Beth |
If it did fire, it wouldn't be hard from the provider side build to implement logic to checkout the HEAD of the main branch, if the |
RE:
contract_requiring_verification_published
webhook.For a brand new integration
mainBranch
property set (The emergent behaviour is the same, whether step is conducted or not)When a new pact file is published, with the
branch
property, and not thetag
property, on the main branchExpected behaviour:-
contract_requiring_verification_published
event is triggered, so provider build is triggered against the latest pact requiring verification on the branch,mainBranch
property is set tomain
Actual behaviour:-
contract_content_changed
event is triggered with note(first time untagged pact published)
This means that the
contract_content_changed
andcontract_requiring_verification_published
are currently not equivalent and the provider build using consumer version selectors needs to be retrieved.The
mainBranch
property is set tomain
(the git branch in the repo) after uploading the pact file, the consumer version selectorsmainBranch: true
pick up the pact and validate it, but only after manually triggering the build.if the pact was uploaded with a
tag
and thepact_changed
webhook was setup, this would have triggered the pact URL driven provider buildAdditional question - Is the main branch property automatically set in the first instance if it is main or master? If one was to start on a feature branch, and
The text was updated successfully, but these errors were encountered: