#150 Prevent invalid URL generation #151
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋
Fix #150
As per its JavaDoc,
PackageURL.percentEncode(String)
is expected to encode the input in conformance with RFC 3986.Regarding encoding, the specification states the following:
When introducing a newline
\n
in the version field, it appears to be encoded as%A
and makes the URL invalid, the good value being%0A
This PR aims to improve this requirement by checking the length of the hexadecimal encoded value and add a leading
0
when needed.Your comments are welcomed, thank you for your time contributing to this project! 🙏