Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seqspec check too strict for corner case #51

Open
hitz opened this issue Oct 22, 2024 · 3 comments
Open

seqspec check too strict for corner case #51

hitz opened this issue Oct 22, 2024 · 3 comments

Comments

@hitz
Copy link

hitz commented Oct 22, 2024

@sidwekhande has an example seqspec: e.g. (https://api.data.igvf.org/configuration-files/IGVFFI0714JZHN/@@download/IGVFFI0714JZHN.yaml.gz but auth required) where the fastq has be demuxed fastqs, our and do not have a truseq_read1 and truseq_read2. However, seqspec starts labeling the fastq sequence starting from the truseq region.

So thesr are submitted truseq regions with the length set to 0, and sequence as null. This triggers:

error 8] None is not of type 'string' in spec['library_spec'][0]['regions'][0]['sequence']
[error 9] None is not of type 'string' in spec['library_spec'][0]['regions'][2]['sequence']

Proposed fix: seqspec check should account for len=0 and ignore this error.

@sbooeshaghi
Copy link
Collaborator

Can you post the seqspec file here so that I can test it? I thought I had fixed this previously..

@hitz
Copy link
Author

hitz commented Oct 22, 2024

There are other errors as well:
IGVFFI0714JZHN-upgrade3.0.yaml.txt

@sbooeshaghi
Copy link
Collaborator

The sequence parameter can be set to '' and the error will go away. This check is already embedded in the spec.schema.json

"if": {
"properties": {
"min_len": {
"const": 0
}
}
},
"then": {
"properties": {
"sequence": {
"type": "string",
"pattern": "^[ACGTRYMKSWHBVDNX]*$"
}
}
},
"else": {
"properties": {
"sequence": {
"type": "string",
"minLength": 1,
"pattern": "^[ACGTRYMKSWHBVDNX]+$"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants