Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userAgent not set when retrieving sitemap #106

Open
nibynool opened this issue Mar 6, 2020 · 0 comments
Open

userAgent not set when retrieving sitemap #106

nibynool opened this issue Mar 6, 2020 · 0 comments

Comments

@nibynool
Copy link

nibynool commented Mar 6, 2020

Expectation

When using the --sitemap <url> option the defaults.userAgent value from the configuration file will be used. If no default.userAgent is defined then the default as defined at https://github.com/pa11y/pa11y#useragent-string will be used.

Actual

pa11y-ci does not set a useragent when retrieving the sitemap url. Instead it uses the node-fetch default value of node-fetch/1.0 (+https://github.com/bitinn/node-fetch).

Additional info

Version: 2.3.0
Sample config file:

{
  "defaults": {
    "userAgent": "My pa11y-ci test runner"
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants