Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Idea: Convert React Class Component to/from Function Component #40

Open
hediet opened this issue Jul 27, 2022 · 1 comment
Open

Comments

@hediet
Copy link

hediet commented Jul 27, 2022

function EditorDemo() {
	return <div className="p-5 mb-4">
		<h2>Editor</h2>

		<div className="mt-4 row row-cols-4">
			<div className="col">
				<label className="control-label">Language</label>
				<select className="language-picker"></select>
			</div>
			<div className="col">
				<label className="control-label">Theme</label>
				<select className="theme-picker">
					<option>Visual Studio</option>
					<option>Visual Studio Dark</option>
					<option>High Contrast Dark</option>
				</select>
			</div>
		</div>

		<div className="mt-2" style={{ height: 500, border: "1px solid gray" }}>
			<MonacoEditor
				model={undefined}
			/>
		</div>
	</div>;
}

<->

class EditorDemo {
	render() {
        return (
            <div className="p-5 mb-4">
                <h2>Editor</h2>

                <div className="mt-4 row row-cols-4">
                    <div className="col">
                        <label className="control-label">Language</label>
                        <select className="language-picker"></select>
                    </div>
                    <div className="col">
                        <label className="control-label">Theme</label>
                        <select className="theme-picker">
                            <option>Visual Studio</option>
                            <option>Visual Studio Dark</option>
                            <option>High Contrast Dark</option>
                        </select>
                    </div>
                </div>

                <div className="mt-2" style={{ height: 500, border: "1px solid gray" }}>
                    <MonacoEditor
                        model={undefined}
                    />
                </div>
            </div>;
        );
    }
}
@lgrammel
Copy link
Contributor

Thanks for the refactoring idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants