Skip to content
This repository has been archived by the owner on Aug 24, 2022. It is now read-only.

Added support for ZONE_FILE #91

Closed
wants to merge 2 commits into from
Closed

Added support for ZONE_FILE #91

wants to merge 2 commits into from

Conversation

devantler
Copy link

I did this in the browser from a phone, and I have not been able to test it.

closes #90

I did this in the browser from a phone, and I have not been able to test it. 

closes #90
@devantler devantler changed the title Added support for ZONE_KEY_FILE and SUBDOMAIN_KEY_FILE Added support for ZONE_FILE Jan 7, 2022
@devantler
Copy link
Author

I just had a second look at this issue. The problem is not solved by my PR.

The issue is here:

getZoneId() {
  cloudflare "$CF_API/zones?name=$ZONE" | jq -r '.result[0].id'
}

Even though ZONE is initialised with ZONE_FILE in 30-cloudflare-setup.sh it does not hold the value when it used in the getZoneId method in the cloudflare.sh script.

I am not so familiar with shell scripts but I think it might be solvable by passing the ZONE variable from the method call in 30-cloudflar-setup.sh such that we get the variable that holds the ZONE value when using ZONE_FILE.

I am closing this PR as it is not helpful, and changing the issue description in #90 to match with my new findings

@devantler devantler closed this Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getZoneId is always using the ZONE environment variable, even when ZONE_FILE is set.
1 participant