Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Show same remove dialog for every kind of file or folder #4377

Open
10 tasks
jesmrec opened this issue Apr 10, 2024 · 0 comments · May be fixed by #4404
Open
10 tasks

[FEATURE REQUEST] Show same remove dialog for every kind of file or folder #4377

jesmrec opened this issue Apr 10, 2024 · 0 comments · May be fixed by #4404

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 10, 2024

This is an improvement from #4342

After such improvement, those files with a thumbnail (images, txt files) show a different dialog including the thumbnail.

But, other items with no thumbnail keep the old dialog. We can complete and use the same dialog for every kind of file or folder, adding the same thumbnail/placeholder displayed in the list of files.

Does this make sense?

TASKS

  • Research (if needed)
  • Create branch feature/feature_name
  • Development tasks
    • Implement whatever
    • ...
    • Implement unit tests (if needed)
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants