-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Av. offline operation does not work correctly when run from a parent folder #4402
Comments
2 tasks
2 tasks
2 tasks
JuancaG05
changed the title
[BUG] Av.offline operation does not work correctly when run from a parent folder
[BUG] Av. offline operation does not work correctly when run from a parent folder
Jun 4, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Actual behaviour
If we have a folder with downloaded files and a subfolder with more downloaded files, if we locally delete one of them and click on Available offline on the parent folder, not all the files will be set as Available offline and this is not correct.
Expected behaviour
When we click
Set available offline
on a folder, all its children must be set as available offline.Steps to reproduce
Folder1
File1 -> downloaded
Folder2
FIle2 -> downloaded
File3 -> downloaded
Unset available offline
.I think the problem comes from this pull request, now our code will only do a sync if the local and remote etags are different. When we click on
Set available offline
, the files contained within folder2 will have the same etag because they have not been modified remotely, therefore they will not be synchronized.This bug also blocks this pull request.
Possible solution:
Create a new parameter in
SynchronizeFolderUseCase
calledisActionSetFolderAvailableOffline
set by default to false. When we perform the operation it will be set to true and a refresh of all the contents of that folder will be performed.This issue is a regressive, so no need to add calens and release notes.
The text was updated successfully, but these errors were encountered: