Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Av. offline operation does not work correctly when run from a parent folder #4402

Closed
Aitorbp opened this issue May 10, 2024 · 0 comments · Fixed by #4403
Closed

[BUG] Av. offline operation does not work correctly when run from a parent folder #4402

Aitorbp opened this issue May 10, 2024 · 0 comments · Fixed by #4403

Comments

@Aitorbp
Copy link
Contributor

Aitorbp commented May 10, 2024

Actual behaviour

If we have a folder with downloaded files and a subfolder with more downloaded files, if we locally delete one of them and click on Available offline on the parent folder, not all the files will be set as Available offline and this is not correct.

Expected behaviour

When we click Set available offline on a folder, all its children must be set as available offline.

Steps to reproduce

  1. If we have the following tree of files in our account:
    Folder1
    File1 -> downloaded
    Folder2
    FIle2 -> downloaded
    File3 -> downloaded
  2. We delete the file file2 locally
  3. We go to the parent folder and set it to av.offline
  4. We wait for the process to finish and click on Unset available offline.
  5. We navigate to folder2 and observe that file2 has not been downloaded.

I think the problem comes from this pull request, now our code will only do a sync if the local and remote etags are different. When we click on Set available offline, the files contained within folder2 will have the same etag because they have not been modified remotely, therefore they will not be synchronized.
This bug also blocks this pull request.

Possible solution:
Create a new parameter in SynchronizeFolderUseCase called isActionSetFolderAvailableOffline set by default to false. When we perform the operation it will be set to true and a refresh of all the contents of that folder will be performed.

This issue is a regressive, so no need to add calens and release notes.

@Aitorbp Aitorbp self-assigned this May 10, 2024
@jesmrec jesmrec added the Sprint label May 24, 2024
@JuancaG05 JuancaG05 changed the title [BUG] Av.offline operation does not work correctly when run from a parent folder [BUG] Av. offline operation does not work correctly when run from a parent folder Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants