[FEATURE REQUEST] Show same remove dialog for every kind of file or folder #4404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aitorbp
force-pushed
the
feature/show_same_remove_dialog_for_every_file_folder
branch
from
6bef5ff
to
98f3ddf
Compare
10 tasks
Aitorbp
force-pushed
the
feature/show_same_remove_dialog_for_every_file_folder
branch
from
5f9c0e0
to
0b29948
Compare
joragua
requested changes
May 21, 2024
Comment on lines
+1154
to
+1155
| filesToRemove = checkedFiles | ||
| fileOperationsViewModel.showRemoveDialog(filesToRemove) |
There was a problem hiding this comment.
It can be used checkedFiles on showRemoveDialog instead of having a variable called filesToRemove
There was a problem hiding this comment.
We cannot delete this variable because it is used in the flow. We would have to change the name there too. I think it's better to leave it like this.
Comment on lines
+82
to
+83
| val file = targetFiles.first() | ||
| messageArguments = file.fileName |
There was a problem hiding this comment.
We can delete file variable and use files.first().fileName on the value of messageArguments
There was a problem hiding this comment.
In this case I would leave it with my approach. If you notice, the file variable is later used to know if the file is a folder, therefore we cannot do without it.
Here the code:
val file = targetFiles.first()
messageArguments = file.fileName
if (file.isFolder) {
R.string.confirmation_remove_folder_alert
} else {
R.string.confirmation_remove_file_alert
}
| @@ -760,6 +760,8 @@ | |||
| <string name="release_notes_4_3_0_subtitle_accessibility_improvements">Some improvements to make the application more accessible</string> | |||
| <string name="release_notes_4_3_0_title_show_app_provider_icon_from_endpoint">New icons in "Open in (web)" option on the operations menu</string> | |||
| <string name="release_notes_4_3_0_subtitle_show_app_provider_icon_from_endpoint">More appropriate icons have been added to the "Open in (web)" option on the operations menu</string> | |||
| <string name="release_notes_4_3_0_title_show_same_remove_dialog_for_every_file_folder">Improved thumbnails in the delete files dialog</string> | |||
| <string name="release_notes_4_3_0_subtitle_show_same_remove_dialog_for_every_file_folder">Thumbnails have been added in remove dialog for all files and not only for images</string> | |||
There was a problem hiding this comment.
Suggested change
| <string name="release_notes_4_3_0_subtitle_show_same_remove_dialog_for_every_file_folder">Thumbnails have been added in remove dialog for all files and not only for images</string> | |
| <string name="release_notes_4_3_0_subtitle_show_same_remove_dialog_for_every_file_folder">Thumbnails have been added in remove dialog for all files and not only for items which had thumbnail</string> |
changelog/unreleased/4404
Outdated
Comment on lines
3
to
4
| The logic of the custom remove files dialog has been incorporated into the RemoveFilesDialogFragment, unifying both developments. | ||
| Thumbnails have been added for all files and not only for images. |
There was a problem hiding this comment.
Suggested change
| The logic of the custom remove files dialog has been incorporated into the RemoveFilesDialogFragment, unifying both developments. | |
| Thumbnails have been added for all files and not only for images. | |
| The logic of the custom remove files dialog has been incorporated into the RemoveFilesDialogFragment, unifying both developments. | |
| Thumbnails have been added for all files and not only for items which had thumbnail. |
Aitorbp
force-pushed
the
feature/show_same_remove_dialog_for_every_file_folder
branch
3 times, most recently
from
1a7a7b2
to
ab533f6
Compare
…ity to display thumbnails(img, mp4, folders...)
…se notes relate to this development
Aitorbp
force-pushed
the
feature/show_same_remove_dialog_for_every_file_folder
branch
from
72c28ff
to
bf7df0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
App: #4377
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA