Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Open deeplinks in app, items already discovered (1st round) #3573

Open
13 of 17 tasks
jesmrec opened this issue Mar 3, 2022 · 7 comments · May be fixed by #3598
Open
13 of 17 tasks

[FEATURE REQUEST] Open deeplinks in app, items already discovered (1st round) #3573

jesmrec opened this issue Mar 3, 2022 · 7 comments · May be fixed by #3598
Assignees
@fesave
Labels
Estimation - 8 (XL) Feature request

Comments

@jesmrec
Copy link
Collaborator

jesmrec commented Mar 3, 2022 •
edited by fesave

Private links generated by the server, must be opened inside the oC Android app.

This is a first approach with specific ACs:

  • App matching the host to be opened when private link is clicked. Not needed to brand this. Static.
  • Working in only one account mode
  • If the link points to a file, the file will be downloaded/displayed
  • If the link points to a folder, the folder content will be displayed
  • If a locking method is set up, the file/folder will be displayed after unlocking
  • If device does not have connection but the file is already downloaded, file is displayed
  • If device does not have connection but the folder is already discovered, content is displayed
  • If the file/folder is not reachable, app is opened and error is shown (toast/snackbar/...)
  • If no accounts are attached in the app, app is opened and error is shown (toast/snackbar/...) (feasible?)

Additional checks:

  • Lack of URL in the scheme (or *) are valid as well.

TASKS

  • Research (if needed)
  • Create branch feature/deep_links
  • Development tasks
    • Implement intent-filter and launch it throught adb's command.
    • App matching the host to be opened when private link is clicked. Not needed to brand this. Static.
    • If no accounts are attached in the app, app is opened and error is shown in toast
    • If the file/folder is not reachable, app is opened and error is shown (toast/snackbar/...)
    • If a locking method is set up, the file/folder will be displayed after unlocking
    • Working in only one account mode
    • If device does not have connection but the folder is already discovered, content is displayed
    • Lack of URL in the scheme (or *) are valid as well.
    • If the link points to a folder, the folder content will be displayed
    • If the link points to a file, the file will be downloaded/displayed
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch feature/feature_name into master

PR
@jesmrec jesmrec mentioned this issue Mar 3, 2022
Open
12 tasks
@jesmrec jesmrec changed the title [FEATURE REQUEST] Open deeplinks in app, items in root folder [FEATURE REQUEST] Open deeplinks in app, items in root folder (1st round) Mar 3, 2022
@jesmrec jesmrec added this to the 2.21-current milestone Mar 16, 2022
@fesave fesave self-assigned this Mar 17, 2022
@jesmrec jesmrec changed the title [FEATURE REQUEST] Open deeplinks in app, items in root folder (1st round) [FEATURE REQUEST] Open deeplinks in app, items already discovered (1st round) Mar 18, 2022
@jesmrec jesmrec added the Sprint label Mar 18, 2022
@fesave
Copy link
Contributor

fesave commented Apr 4, 2022

Hi @tbsbdr!!!! We need to add some new action buttons to the detail screen and here we post three proposals that we have designed. what do you think about it? New ideas or contributions are welcome!!!!

cc @michaelstingl @abelgardep @jesmrec @theScrabi @davcres

Options

First Option Second Option Third Option
option_one option_two option_three

@michaelstingl
Copy link
Contributor

michaelstingl commented Apr 4, 2022 •
edited

Did you consider "Open in…" / "Open with…" instead of "Send" ? What do others do?

@fesave
Copy link
Contributor

fesave commented Apr 4, 2022 •
edited

Did you consider "Open in…" / "Open with…" instead of "Send" ? What do others do?

The download button would change the text to "Open in..." or "Open with..." once the file has been downloaded. What do you think?

@jesmrec
Copy link
Collaborator Author

jesmrec commented Apr 4, 2022 •
edited

2nd one is awful for me

The download button would change the text to "Open in..." or "Open with..." once the file has been downloaded. What do you think?

i guess, depending on the openability of the file, right?

@fesave fesave linked a pull request Apr 5, 2022 that will close this issue
Open
7 tasks
@fesave fesave linked a pull request Apr 5, 2022 that will close this issue
Open deep links in app, items already discovered (1st round) #3598
Open
7 tasks
@tbsbdr
Copy link

tbsbdr commented Apr 5, 2022 •
edited

shot from the hip:

  • left aligned with icons
  • style: some "secondary" (= more decent) button style if something like this exists in the android app. (currently i see 3 "primary" actions which is quite loud in my perception. )

Scribble:

image

known patterns / examples from other apps:

image

@fesave
Copy link
Contributor

fesave commented Apr 26, 2022 •
edited

Hi @dragotin , @michl19 👋🏻 The First feature we should discuss!!!

As a result of last Monday's meeting, we have developed a solution to the problem of the deep link discussed that day.

As we can see in the first video, if the user clicks on the thumbnail (not applicable to video files), the image is downloaded and previewed, and the following times (as it is already downloaded) it will only be previewed. But we think it is an easter egg for the user because there is nothing to tell him if he clicks on the thumbnail he will be able to see it in detail.

deep_link_click_thumbnail.mp4

The second video I attach is a solution to the previous problem, the button is not final and is subject to changes in design and text.

deep_link_click_button.mp4

We would like to know what you think about it and what solution you like the most. Thanks!

cc @abelgardep @jesmrec @davcres

@dragotin
Copy link

I think both solutions are pretty good, but I would prefer the first one. I think it is clear nowadays that clicking on a thumbnail opens the file.
But ... @tbsbdr will have an opinion ;-)

@fesave fesave added Sprint and removed Sprint labels Apr 29, 2022
@jesmrec jesmrec removed the Sprint label May 24, 2022
@jesmrec jesmrec modified the milestones: 2.21-current, 2.22-next May 24, 2022
@jesmrec jesmrec removed this from the 4.2 - Future milestone Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fesave fesave

Labels
Estimation - 8 (XL) Feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Open deep links in app, items already discovered (1st round) owncloud/android
6 participants
@michaelstingl @dragotin @jesmrec @tbsbdr @abelgardep @fesave