Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attach issue to pull request, refer it instead #193

Open
owenthereal opened this issue Feb 4, 2014 · 2 comments
Open

Don't attach issue to pull request, refer it instead #193

owenthereal opened this issue Feb 4, 2014 · 2 comments

Comments

@owenthereal
Copy link
Owner

With the new changes on API, it's not recommended to attach a PR to an issue. It's recommended to refer to an issue instead. One solution is to create a pull request and refer to an issue in the pull request.

$ gh pull-request -i 123
creates a pull request (don't use the attach issue API since it'll convert an issue to a PR)
posts a message to issue 123, e.g. pull request 456 has been created

/cc @calavera @technoweenie @mislav

@calavera
Copy link
Contributor

calavera commented Feb 4, 2014

👍

We can create the title and description based on the issue referenced.

@mislav
Copy link
Collaborator

mislav commented Feb 4, 2014

Yep, you could prefill the PR body with Fixes #XYZ. This gives the user an option to edit the message, and lets GitHub handle the issue references (i.e. you don't have to manually post a comment to issue XYZ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants