Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Factor more remote fields into local search #659

Open
Bwc9876 opened this issue Aug 8, 2024 · 1 comment · May be fixed by #621
Open

[Feature Request] Factor more remote fields into local search #659

Bwc9876 opened this issue Aug 8, 2024 · 1 comment · May be fixed by #621
Assignees
@Bwc9876
Labels
core enhancement New feature or request pending-release

Comments

@Bwc9876
Copy link
Member

Bwc9876 commented Aug 8, 2024

Package

Core Package

Feature

Currently LocalDatabase::search_with_remote only clones the remote mod's name, expand this to include:

  • description
  • author (RemoteMod::get_author, not the direct field)

Platform

No response
@Bwc9876 Bwc9876 added enhancement New feature or request core labels Aug 8, 2024
@Bwc9876 Bwc9876 self-assigned this Aug 8, 2024
@Bwc9876 Bwc9876 linked a pull request Aug 8, 2024 that will close this issue
Draft
@Bwc9876
Copy link
Member Author

Bwc9876 commented Aug 8, 2024

Ended up just doing .chain(remote.get_values()), that way any changes to how remote mod search works extends to local as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bwc9876 Bwc9876

Labels
core enhancement New feature or request pending-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 0.15.0 ow-mods/ow-mod-man
1 participant
@Bwc9876