Skip to content
This repository has been archived by the owner on Sep 24, 2020. It is now read-only.

\ PHPSA\AliasManager::add and isClassImported aren't complementary to each other #173

Closed
DannyvdSluijs opened this issue Oct 4, 2016 · 2 comments

Comments

@DannyvdSluijs
Copy link

At https://github.com/ovr/phpsa/blob/master/src/AliasManager.php#L51 the namespace is added to the aliases array using numerical indexes, where is the isClassImported checks for the namespace to be available as a key.

This was discovered during writing the UT mentioned in #170 .

@ddmler
Copy link
Collaborator

ddmler commented Oct 4, 2016

We should change isClassImported to use numerical indexes then. 👍

@DannyvdSluijs
Copy link
Author

Will create a fix today or tomorrow

Sent from my iPhone

On 4 Oct 2016, at 21:13, Enrico [email protected] wrote:

We should change isClassImported to use numerical indexes then. 👍


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

om3rcitak added a commit to om3rcitak/phpsa that referenced this issue Oct 4, 2016
delete line for ovr#175 (comment)
@ddmler ddmler closed this as completed in dcc4bca Oct 4, 2016
ddmler pushed a commit that referenced this issue Oct 4, 2016
ddmler pushed a commit that referenced this issue Oct 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants