-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check benchmarks in CI #883
Labels
enhancement
help wanted
optimization
Related to performance optimizations
tests
Linked to library tests
Comments
brandonwillard
added
enhancement
tests
Linked to library tests
optimization
Related to performance optimizations
help wanted
labels
May 9, 2024
Good reading materials @brandonwillard Here are some examples I found of ASV in use:
ASV seems like a great solution, it can be run in GitHub Actions while minimizing comparison error, is widely used by major python libraries, and appears to have relatively easy setup. Happy to get started on this if you agree! |
Note that we should track both execution speed and memory usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
help wanted
optimization
Related to performance optimizations
tests
Linked to library tests
We need an Actions/CI step that automatically compares benchmark results against current
main
and notifies us when there is a significant regression before a PR is merged.We've used
github-actions-benchmark
in the past, but it seemed overly complicated, was more about serving a website with benchmark results (which is complexity we don't need right now), and wasn't actually able to perform the desired checks on each PR—at least not without some undesirable trade-offs.If anyone knows of an existing workflow we can adapt, or alternative Action, please tell us!
N.B. https://labs.quansight.org/blog/2021/08/github-actions-benchmarks
The text was updated successfully, but these errors were encountered: