Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check benchmarks in CI #883

Closed
brandonwillard opened this issue May 9, 2024 · 2 comments · Fixed by #903
Closed

Check benchmarks in CI #883

brandonwillard opened this issue May 9, 2024 · 2 comments · Fixed by #903
Assignees
Labels
enhancement help wanted optimization Related to performance optimizations tests Linked to library tests

Comments

@brandonwillard
Copy link
Contributor

brandonwillard commented May 9, 2024

We need an Actions/CI step that automatically compares benchmark results against current main and notifies us when there is a significant regression before a PR is merged.

We've used github-actions-benchmark in the past, but it seemed overly complicated, was more about serving a website with benchmark results (which is complexity we don't need right now), and wasn't actually able to perform the desired checks on each PR—at least not without some undesirable trade-offs.

If anyone knows of an existing workflow we can adapt, or alternative Action, please tell us!

N.B. https://labs.quansight.org/blog/2021/08/github-actions-benchmarks

@brandonwillard brandonwillard added enhancement tests Linked to library tests optimization Related to performance optimizations help wanted labels May 9, 2024
@lapp0
Copy link
Contributor

lapp0 commented May 17, 2024

Good reading materials @brandonwillard

Here are some examples I found of ASV in use:

ASV seems like a great solution, it can be run in GitHub Actions while minimizing comparison error, is widely used by major python libraries, and appears to have relatively easy setup.

Happy to get started on this if you agree!

@rlouf
Copy link
Member

rlouf commented May 17, 2024

Note that we should track both execution speed and memory usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted optimization Related to performance optimizations tests Linked to library tests
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants