Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have you ever considered exporting the rtmp protocol as an independent golang library? #61

Open
Akagi201 opened this issue Apr 22, 2016 · 1 comment

Comments

@Akagi201
Copy link
Contributor

Akagi201 commented Apr 22, 2016

I dive into the protocol directory.

I found that the protocol sub-package only depends on core/utility.go and core.Context.

I think you can create a util sub-package and put core/utility.go and core.Context in it.

What do you think of it? Or I can do it myself, and make a PR.

Append...

The protocol sub package also depends on config.go and logger.go. It may be not easy to export the protocol package.

@winlinvip
Copy link
Member

winlinvip commented May 3, 2016

Good idea, we should export the protocol to https://github.com/ossrs/go-oryx-lib. Please file a PR~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants