Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does the Wikidata script select a Facebook icon? #10116

Open
UKChris-osm opened this issue Nov 2, 2024 · 1 comment
Open

How does the Wikidata script select a Facebook icon? #10116

UKChris-osm opened this issue Nov 2, 2024 · 1 comment
Labels
javascript Pull requests that update Javascript code question Not Actionable - just a question about something

Comments

@UKChris-osm
Copy link
Collaborator

UKChris-osm commented Nov 2, 2024

While looking at another issue, I noticed that McDonalds is using the South Africa Facebook Logo, which currently doesn't show a meaningful McD's logo.

This isn't an issue as such, as dist_files.js already overrules Facebook to use a Commons Logo, but it did make me wonder why the South African Facebook logo is being chosen by the Wikidata script over the main McDs Facebook, when the main one has a preferred rank.

Is it because the South Africa one is the last in the list, does the Wikidata script not factor in rank?

@UKChris-osm UKChris-osm added question Not Actionable - just a question about something javascript Pull requests that update Javascript code labels Nov 2, 2024
@1ec5
Copy link
Member

1ec5 commented Nov 4, 2024

The script does prefer any statement with preferred rank, so I’m unsure why that isn’t working:

// - accept immediately any claim with "preferred" rank
// P2013 - Facebook ID
const facebookUser = getClaimValue(entity, 'P2013');

It’s only showing up now because someone recently dumped a ton of regional statements onto the global McDonald’s item, even though each regional subsidiary already has its own item, including McDonald’s South Africa (Q27923821). I’m tempted to simply revert the changes, but probably the better option would be to move the statements to the appropriate items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code question Not Actionable - just a question about something
Projects
None yet
Development

No branches or pull requests

2 participants