-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Subatlas functionality #278
Labels
Comments
May I suggest a usage for https://github.com/osmlab/atlas/blob/dev/src/main/java/org/openstreetmap/atlas/utilities/filters/IntersectionPolicy.java? As the return value for different cut policies that can then be used by the the matcher when given a GeometricSurface(polygon). |
#334 partially addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per discussion in PR #276, there are two ideas to try here:
Would it ever be possible to have subAtlas(Polygon) call subAtlas(matcher) underneath? It feels like the should really do the same thing, but subAtlas(Polygon) is a convenience method.
Does it make sense to have a subAtlas base class or interface? If 1 above can be done, there can be a default implementation for subAtlas(Polygon) and there could be a centralized source for logging and the packaging of the packed atlas.
The text was updated successfully, but these errors were encountered: