Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate limiting algos should handle error on unsussesful redis connection #45

Open
evanmcneely opened this issue Jun 2, 2022 · 0 comments
Open

Rate limiting algos should handle error on unsussesful redis connection #45

evanmcneely opened this issue Jun 2, 2022 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@evanmcneely
Copy link
Contributor

when making a redis command like setex() or get(), if the connection to redis fails the function will fail silently. Refactor the algo to handle these edge cases.
@shalarewicz shalarewicz added the enhancement New feature or request label Jun 13, 2022
@shalarewicz shalarewicz mentioned this issue Jul 27, 2022
Merged
1 task
@evanmcneely evanmcneely changed the title refactor token bucket algo to handle error on unsussesful redis connection Rate limiting algos should handle error on unsussesful redis connection Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shalarewicz @evanmcneely