Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with redis functions to do cache side computations of ratelimiting computations #42

Open
evanmcneely opened this issue Jun 2, 2022 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@evanmcneely
Copy link
Contributor

Our token bucket algo is currently getting data from the redis cache and doing computations server side. 'Redis Functions' allow the redis store to carry out computations on the redis's side, which possibly decreases the number of requests made to speed up the algorithm. Try this out to see if it actually has any performance differences.

@shalarewicz shalarewicz added enhancement New feature or request question Further information is requested labels Jun 13, 2022
@evanmcneely
Copy link
Contributor Author

see Lua scripting

@shalarewicz
Copy link
Collaborator

Consider either SortedSet or List for use in SlidingWindowLog. Will most likely require a lua script to be purely server side.
Hashes may be useful for remaining limiters and may not require a lua script

@evanmcneely evanmcneely changed the title Use redis functions to do cache side computations of token bucket totals, etc. Experiment with redis functions to do cache side computations of ratelimiting computations Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants