Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all use ::* #204

Open
oscartbeaumont opened this issue Dec 24, 2023 · 1 comment
Open

Remove all use ::* #204

oscartbeaumont opened this issue Dec 24, 2023 · 1 comment
Labels
breaking change This will probs end up in the next major version.

Comments

@oscartbeaumont
Copy link
Member

It's both bad for semver and also can cause unintended LSP hints.

Right now Rust Analyser wants to import FunctionDataType from specta::js_doc::FunctionDataType not specta::functions::FunctionDataType
@oscartbeaumont
Copy link
Member Author

Also, look at src/lib.rs:

#[doc(hidden)] // TODO: Should we actually do this? I think not
pub use datatype::*;

@oscartbeaumont oscartbeaumont added the breaking change This will probs end up in the next major version. label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change This will probs end up in the next major version.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oscartbeaumont