Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The schema 'errorBrowserLocationChangeRequired' has an error nested within another error. #3832

Open
3 of 5 tasks
iBakuman opened this issue Mar 20, 2024 · 0 comments
Open
3 of 5 tasks
Labels
bug Something is not working.

Comments

@iBakuman
Copy link

iBakuman commented Mar 20, 2024

Preflight checklist

Ory Network Project

No response

Describe the bug

The schema component errorBrowserLocationChangeRequired defined in openapi spec(spec/api.json) specifies the following JSON structure:

{
  "error": {
    "error": {
       ...
    }
  }
  "redirect_browser_to": ...
}

However, the actual recovery flow returns:

{
    "error": {
      ....
    },
    "redirect_browser_to": ...
}

It seems like the error field of errorBrowserLocationChangeRequired should reference #/components/schemas/genericError instead of #/components/schemas/errorGeneric

Reproducing the bug

curl --location --request POST 'https://{{your_host}}/self-service/recovery?flow=b0860133-105b-4ac3-9170-b49b1f7fc968' \
--header 'Cookie: csrf_token_1fe95deebbea7d7af1341e9b55ee6c161b77e22b3f5a8caaf9866a8e0da91c52=nqJN4P+TIb+aiZk5iKb1AI5jQoCzof3JfXTFF+GpDow=' \
--header 'Accept: application/json' \
--header 'User-Agent: Apifox/1.0.0 (https://apifox.com)' \
--header 'Content-Type: application/json' \
--header 'Cache-Control: no-cache' \
--header 'Host: {{your_host}}
--header 'Connection: keep-alive' \
--data-raw '{
    "method": "code",
    "code": "515514",
    "csrf_token": "9ZeTasVnNqB7XLf7ZzWGAuMJKyW03rgTmPRR2dx9XxFrNd6KOvQXH+HVLsLvk3MCbWpppQd/RdrlgJTOPdRRnQ=="
}'

Relevant log output

No response

Relevant configuration

No response

Version

v1.1.0

On which operating system are you observing this issue?

macOS

In which environment are you deploying?

Docker

Additional Context

No response

@iBakuman iBakuman added the bug Something is not working. label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

1 participant