-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
offline mode #265
Comments
I'm gonna give this a shot |
All yours! :) |
heya! Just checking in. You seem to have gotten pretty far. Are you still interested in getting a PR set up for this? Anything I can help with? |
Hi! Sorry--lots of not great personal life stuff has happened and so it's probably best for someone to pick up with this WIP (or start over if they prefer). If you're okay waiting I may be able to get back to this in a couple months. Again, really sorry! |
Much like NPM, we should support an "offline" mode that errors out if a package isn't already in the cache.
This can be implemented by a combination of three changes:
oro-client
for metadata requests (no need to worry about it for tarballs)nassun::Package::extract_to_dir_inner
such that if it's true, it will only try to doself.extract_from_cache
instead of all the fallback logic.--offline
global flag (or maybe it should be inApplyArgs
?) and thread it through to the right places.The rest is just making sure the error messages are good.
Overall, this shouldn't be a very challenging task but it does involve touching a good number of places in the code.
The text was updated successfully, but these errors were encountered: