Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offline mode #265

Open
zkat opened this issue May 12, 2023 · 4 comments
Open

offline mode #265

zkat opened this issue May 12, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@zkat
Copy link
Member

zkat commented May 12, 2023

Much like NPM, we should support an "offline" mode that errors out if a package isn't already in the cache.

This can be implemented by a combination of three changes:

  1. Add support for passing in a CacheMode to oro-client for metadata requests (no need to worry about it for tarballs)
  2. Add an option to nassun::Package::extract_to_dir_inner such that if it's true, it will only try to do self.extract_from_cache instead of all the fallback logic.
  3. Expose an --offline global flag (or maybe it should be in ApplyArgs?) and thread it through to the right places.

The rest is just making sure the error messages are good.

Overall, this shouldn't be a very challenging task but it does involve touching a good number of places in the code.

@zkat zkat added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 12, 2023
@zkat zkat mentioned this issue May 12, 2023
6 tasks
@hibachrach
Copy link

I'm gonna give this a shot

hibachrach added a commit to hibachrach/orogene that referenced this issue May 15, 2023
@zkat
Copy link
Member Author

zkat commented May 15, 2023

All yours! :)

hibachrach added a commit to hibachrach/orogene that referenced this issue May 16, 2023
hibachrach added a commit to hibachrach/orogene that referenced this issue May 16, 2023
hibachrach added a commit to hibachrach/orogene that referenced this issue May 16, 2023
@zkat
Copy link
Member Author

zkat commented Sep 30, 2023

heya! Just checking in. You seem to have gotten pretty far. Are you still interested in getting a PR set up for this? Anything I can help with?

@hibachrach
Copy link

Hi! Sorry--lots of not great personal life stuff has happened and so it's probably best for someone to pick up with this WIP (or start over if they prefer). If you're okay waiting I may be able to get back to this in a couple months. Again, really sorry!

@hibachrach hibachrach removed their assignment Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: In Progress
Development

No branches or pull requests

2 participants