Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stable rust for cargo-fmt #618

Open
1 task done
MarcoIeni opened this issue Apr 21, 2024 · 0 comments
Open
1 task done

Use stable rust for cargo-fmt #618

MarcoIeni opened this issue Apr 21, 2024 · 0 comments
Assignees
Labels
feature/request New feature or request good first issue Good for newcomers

Comments

@MarcoIeni
Copy link
Sponsor Contributor

MarcoIeni commented Apr 21, 2024

Is there an existing issue or pull request for this?

  • I have searched the existing issues and pull requests

Feature description

Not really a feature.
working with cargo nightly for cargo fmt is painful :(
Please, consider switching to stable to make the experience of contributors a bit better.

Desired solution

  • Remove rust-toolchain.toml file
  • Run cargo fmt

Downside: all opened PRs will have merge conflicts probably because stable uses spaces instead of tabs. So it's better to do this when there aren't big PRs opened.

Alternatives considered

The alternative is keeping the current configuration I guess.

Additional context

feedback coming from #613 (comment)

@MarcoIeni MarcoIeni added the feature/request New feature or request label Apr 21, 2024
@orhun orhun added the good first issue Good for newcomers label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/request New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants