GitHub Community
Virtual rendering implementation behaves differently on Firefox, causing worse performance. #77953
-
Select Topic AreaBug BodyOver in Mozilla bug 1868316, we got a report of some kinds of files being much slower in Firefox compared to other browsers. https://github.com/MaoJianwei/eAIP-2015-Nr.13/blob/master/Download_eAIP_2015_Nr.13.py is an extreme example of this. While investigating, I realized that the DOM that GitHub ends up with is substantially (530x) larger on Firefox than on Chromium (829448 vs. 1556). That was done via It seems there's something about the virtualization of the code view that doesn't work in Firefox, or at least works differently to Chromium? If it was due to something misbehaving in Firefox, I'd be happy to help diagnose and address it, but tentatively filing here. Thank you! |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 7 replies
-
|
Hey @emilio! Since the associated Mozilla bug is closed I am no longer able to comment on it. I just wanted to follow up to let you know that we've updated our code rendering to accommodate the Additionally, prior to the I appreciate you pushing the |
Beta Was this translation helpful? Give feedback.
-
|
Same! Thanks for all your help with this! |
Beta Was this translation helpful? Give feedback.
-
|
For reference, Chromium folks filed https://issues.chromium.org/issues/325372936 for this, and I just filed https://bugs.webkit.org/show_bug.cgi?id=269909 for WebKit. When all browsers implement this, you could simplify your rendering even further by avoiding all the pseudo-element shenanigans. |
Beta Was this translation helpful? Give feedback.
-
|
Hey Emilio, thanks again for all of your help on this! In your experience, what is the approximate timeline for chromium/webkit to fix issues like this? |
Beta Was this translation helpful? Give feedback.
-
|
Hard to know, really depends on the complexity of the fix and the relative priority. My guess is that this shouldn't be a hard fix. |
Beta Was this translation helpful? Give feedback.
-
|
Hopefully they give it high priority! |
Beta Was this translation helpful? Give feedback.
Hey @emilio!
Since the associated Mozilla bug is closed I am no longer able to comment on it. I just wanted to follow up to let you know that we've updated our code rendering to accommodate the
user-findprototype you implemented. We are now doinguser-findsupport detection and changing our rendering strategy to match non-Firefox browsers. 🎉Additionally, prior to the
user-findimprovement, we did ship a few changes that should have helped performance a bit for standard Firefox users.I appreciate you pushing the
user-findefforts forward with the CSSWG! If you find any issues with ouruser-findimplementation or have anything else we can help, please let us know.