GitHub Community
Allow Organizations/Repos to make pull requests drafts by default #6943
Replies: 27 comments 10 replies
-
|
And this forum posting. The particular use-case for this is organizations that have CODEOWNERS. Adding code owners when the PR is initially opened is premature. It could go through lots of iterations before it's ready for review, so code owners don't actually know when this is. However since draft PRs don't add CODEOWNER reviewers, this confusion is avoided and when the PR is finally ready for review it can be converted to non-draft PRs at which time CODEOWNERS would be added. |
Beta Was this translation helpful? Give feedback.
-
|
+1 for this. We are relying on draft pull requests to reduce the GitHub Action minutes we spend in a large monorepo in order to save computing time and money. Right now we include a message reminding developers to create PRs as "draft" in the pull request template, but automating this would be much better. I wrote about this here: https://engineering.leanix.net/blog/halve-your-github-actions-bill/ |
Beta Was this translation helpful? Give feedback.
-
|
This would be a huge help for us, as well. Maintaining a monorepo using PullApprove pings for reviews immediately after a PR is opened. Once that PR is converted to draft, the requests are still present and maintained. It creates a bunch of noise. Defaulting to creating a draft PR would be wonderful because so many people forget to create as draft until after they clicked to create PR. |
Beta Was this translation helpful? Give feedback.
-
|
+1. We often have PRs that are opened and abandoned in a non-obviously incomplete state. It would be great if these PRs didn't consume review bandwidth. |
Beta Was this translation helpful? Give feedback.
-
|
@Xavientois and I have open-sourced A Github Action that sets a PR to Draft when it is opened: https://github.com/marketplace/actions/mark-pr-as-draft |
Beta Was this translation helpful? Give feedback.
-
|
@xavidop this appears to change Open PRs to Draft state. This, unfortunately, doesn't really solve the problem because once the PR is in Open state all the automation already happens. |
Beta Was this translation helpful? Give feedback.
-
|
+1 I know this is a silly use-case but PR-drafts-by-default would help alleviate a common problem with the Github/Slack integration where Pull Request previews show too much detail in Slack. Draft PRs do not show the same amount of detail, so our team will default to drafts and then on the PR right away. |
Beta Was this translation helpful? Give feedback.
-
|
Yes pls 😍 Is this already worked on or planned or something? |
Beta Was this translation helpful? Give feedback.
-
|
We are currently migrating some projects over to GitHub and are also looking for ways to configure draft to be the default for all the reasons mentioned above. |
Beta Was this translation helpful? Give feedback.
-
|
Commenting as we are looking to do this for our org as well. |
Beta Was this translation helpful? Give feedback.
-
|
Our case for this is for deployments. To deploy, developers raise a PR into |
Beta Was this translation helpful? Give feedback.
-
|
I would love this for our org as well. Tired of the extra click to set things to draft for every new PR. |
Beta Was this translation helpful? Give feedback.
-
|
Check out Refined GH: https://github.com/refined-github/refined-github It pulls the draft option out into its own button, so it's a one-click operation just like opening a non-draft PR: https://user-images.githubusercontent.com/34235681/152473201-868ad7c1-e06f-4826-b808-d90bca7f08b3.png (It also does a million other very nice/useful/time-saving things. Scroll down in the repo's readme to see the list. And no, I'm not affiliated with the author in any way, just a HUGE fan of his extension.) |
Beta Was this translation helpful? Give feedback.
-
|
Fair enough. But this only applies a personal preference. I am looking to set policy for all members of an organisation or all pull requests for a repo without having to have users "cooperate" and install a browser plugin and configure it accordingly. |
Beta Was this translation helpful? Give feedback.
-
|
I can't agree with this more! It would be great to be able to set this to the default for all repos in an Enterprise Org to be honest. We don't need all our actions working and running when someone may just be committing code to allow someone else to be able to see the changes. The fact that we have actions running when the commit is there is costly when we can't seem to get people to make sure they are DRAFT status to prevent CI to run. |
Beta Was this translation helpful? Give feedback.
-
|
+1 on this request - I would actually like an option to completely disable the ability to create non-draft PRs on a repo. For the few situations where someone really does want to create a non-draft PR immediately (e.g. bot-generated PRs) then it should not be difficult for the user in that situation to add the extra step of converting the PR from draft to ready. |
Beta Was this translation helpful? Give feedback.
-
|
+1 on this request. We run extensive automation tests on branches in a large monorepo prior to merging to main. We have our ci configured to only run against non-draft PRs and have to tell developers to remember to open PRs as drafts until they are ready to run the full automation suite against them. |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
Use github cli for this, you can pass |
Beta Was this translation helpful? Give feedback.
-
|
How do you enforce this on a team level? |
Beta Was this translation helpful? Give feedback.
-
|
@bazinga012 Thanks. But this discussion is not about how to open PRs as drafts. We all know how to do this already. This discussion is about an organization (or even repo) switch/option to make PRs open as drafts by default for everyone. |
Beta Was this translation helpful? Give feedback.
-
|
In addition to the above suggestion: Implementation Suggestion
|
Beta Was this translation helpful? Give feedback.
-
|
This would be very beneficial to our use-case as well - we would like pre-merge checks to take place before CODEOWNER notifications are sent out. |
Beta Was this translation helpful? Give feedback.
-
|
+1, would really really help us to manage our CRs better, cuz we have automations that runs on ready-for-review PRs and nudge us to review them :) |
Beta Was this translation helpful? Give feedback.
-
|
I feel like someone already mentioned this but curious what I'm missing and why it was overlooked. Couldn't you just use the github action from: https://github.com/orgs/community/discussions/6943#discussioncomment-2592012 and have this be the very first thing in the pipeline. So once its opened, it basically immediately goes to Draft? |
Beta Was this translation helpful? Give feedback.
-
|
Did you see the reply on the suggestion you have referred to? |
Beta Was this translation helpful? Give feedback.
-
|
I did but I didnt understand it until literally just now as I tried my own suggestion and see the problem haha! Shoot! |
Beta Was this translation helpful? Give feedback.
-
|
I'm wondering if there's a way to do it through depending on another yml file.. |
Beta Was this translation helpful? Give feedback.
-
|
@brianjmurrell If you're curious, I think I found a solution! So I use the draft script on |
Beta Was this translation helpful? Give feedback.
-
|
+1, great idea |
Beta Was this translation helpful? Give feedback.
and others
-
My organization wants to try out a new flow for pull requests where most PRs should be opened as drafts rather than as ready.
It would be useful for us to be able to set up our repos to show the
Create draft pull requestsbutton by default rather than theCreate pull requestwhen opening a new PR.Based on the existence of this extension and this issue shows that there as least some level of demand for configurability here.
Beta Was this translation helpful? Give feedback.
All reactions