GitHub Community
Create Pull Requests on Mobile #6348
Replies: 23 comments 28 replies
-
|
Thanks for the note @Sherlock-HolmesJM — are you envision that this feature would include file editing and committing from your phone? It would be helpful for us if you could share a few more details about what kind of flow you're in where opening a pull request on mobile would be helpful. Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
Merely commenting to express that I too would find this helpful. Hopefully this helps feature request gain traction. The first bullet point would be a great start. Ability to create PR from app. |
Beta Was this translation helpful? Give feedback.
-
|
I was looking to create a PR just now too. I too don't care about editing the files, I just want to create a PR from a branch that has recently seen changes. |
Beta Was this translation helpful? Give feedback.
-
|
Same here! For example, you did all the necessary changes, you pushed your commits but you forgot to open a PR and you already closed your laptop and you're on your way... It would be very helpful to just pick a branch and create the PR from the app. |
Beta Was this translation helpful? Give feedback.
-
|
Couple of years and still can't create a PR |
Beta Was this translation helpful? Give feedback.
-
|
Most probably the dev that implemented this feature throughout these 2 years has the latest source ready in his branch but its afk and cannot create the PR from the mobile app. |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
This needs to happen..I may not be around my laptop but always with my phone |
Beta Was this translation helpful? Give feedback.
-
|
It has been two years since this post and it is still not implemented. I also cant have the github app installed for 2fa and open a pull request in a browser, since it automatically opens the app... |
Beta Was this translation helpful? Give feedback.
-
|
Hi @Niteletsplay. Editing code and creating pull requests is already available on Android and iOS. If you have any feedback about the feature, let us know! |
Beta Was this translation helpful? Give feedback.
-
|
Hi @aconsuegra |
Beta Was this translation helpful? Give feedback.
-
|
As I mentioned in this comment, creating pull requests from existing branches is not possible, yet. But editing files, committing changes, creating a branch and opening a pull request is available. |
Beta Was this translation helpful? Give feedback.
-
|
I’ve just been reading through the existing discussion about this. Like others, the thing that would actually be useful to me is to create a pull request from an existing branch. In my case, it would be handy so that I can check through my own changes while I’m not near my PC before getting others to review them. Sometimes I forget to put in a pull request before leaving my PC, and I’d like to do that on mobile. In terms of feedback on the existing feature: I’m unlikely to want to edit code directly on my phone without at least some kind of external keyboard, so it doesn’t seem that useful to me personally. I’ve already had thumb tendinitis once in life, and that was enough. Plus it’s slow to work that way, annoying to switch between files, and hard to see enough code at once, especially across multiple files. Conversely, the requested feature has none of those drawbacks, and would be useful out of the box. |
Beta Was this translation helpful? Give feedback.
-
|
Any updates on this? |
Beta Was this translation helpful? Give feedback.
-
|
In my professional opinion, I believe the ability to create pull requests from existing branches is a highly valuable and more critical feature which will require significantly less effort to implement than creating and committing new files; and hence should be prioritised. |
Beta Was this translation helpful? Give feedback.
-
|
Definetily |
Beta Was this translation helpful? Give feedback.
-
|
I don't think anyone wants to edit code on his phone he rather wants to create a pull request for code he already pushed and tested on his PC. |
Beta Was this translation helpful? Give feedback.
-
Exactly!! |
Beta Was this translation helpful? Give feedback.
-
Jokes on you I did, pain. |
Beta Was this translation helpful? Give feedback.
-
YES ! |
Beta Was this translation helpful? Give feedback.
-
|
How sway |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as spam.
This comment was marked as spam.
-
|
This is such as a bad ux I need to open a pr from my phone and it keeps redirecting me to the mobile app |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
Well hopefully a rabbit from my hat
…On Thu, Jan 11, 2024, 8:29 AM Vahid8478 ***@***.***> wrote:
Thanks for the note @Sherlock-HolmesJM — are you envision that this
feature would include file editing and committing from your phone? It would
be helpful for us if you could share a few more details about what kind of
flow you're in where opening a pull request on mobile would be helpful.
Thanks!
—
Reply to this email directly, view it on GitHub
<#6348 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBHEXGSFSTCIWC5S2FPR633YN7ZOFAVCNFSM5F77NT42U5DIOJSWCZC7NNSXTOKENFZWG5LTONUW63SDN5WW2ZLOOQ5TQMBZGYYTSNQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|
Beta Was this translation helpful? Give feedback.
-
|
Any progress on this? The only reason I open GitHub when out of my PC is to review PRs and create new ones from existing branches. |
Beta Was this translation helpful? Give feedback.
-
|
Please any update? I wish I can do this as well |
Beta Was this translation helpful? Give feedback.
-
|
Yeah, this need to be implemented... |
Beta Was this translation helpful? Give feedback.
-
|
No Updates Yet 🙄 |
Beta Was this translation helpful? Give feedback.
-
|
So I kinda got tired of waiting for this feature so I make minor changes in the app and then raise a PR from my mobile browser .. seems unnecessarily complicated tho |
Beta Was this translation helpful? Give feedback.
-
|
Hi @SreevarshPV, thanks for your feedback! Creating pull requets from the GitHub Mobile app is possible after you edit a file and commit your changes. Are you expecting a different behavior? |
Beta Was this translation helpful? Give feedback.
-
|
I think most are looking for the ability to create a PR from an already existing branch that has existing committed changes without requiring someone to edit a file from the app. For example, you committed changes to a new branch on your computer and left the office, but forgot to submit a PR. I would like to able to open the app, view a branch, and simply submit a PR. If we look at this comment from @brianlovin, I think most are looking for 1, not 2 (which the latter seems to have already been implemented). |
Beta Was this translation helpful? Give feedback.
-
|
@aconsuegra I think it is very clear from the comments that people are looking for the opportunity to create PRs from existing branches without editing anything. I don't see why this should be such a difficult feature to implement, as creating PRs from edited files is obviously already a thing. That being said, I think most would never even want to edit a file in the app, let alone create a PR for it. On the other hand, leaving the office and reviewing your own code on your way home and then creating a PR if it looks good is probably a scenario many are familiar with. Please implement this. |
Beta Was this translation helpful? Give feedback.
-
|
You might be thinking “Why do you want to create PRs on the mobile phone” and decide not to prioritize developing this feature. But hear me out. Sometimes I commit changes but forget to create a PR and then I shut down my computer. Currently, I have to restart my computer and wait for it to boot just to create a PR and shut it down again. So it would be extremely convenient if we have the ability to create PRs on the mobile app in scenarios like that. So please consider developing this feature. Thanks for developing this awesome app. This truly is one of the best iOS apps ever. |
Beta Was this translation helpful? Give feedback.
-
|
This is such a simple feature to have event doesn't need any special UX or any complicated service, why is this feature not present yet |
Beta Was this translation helpful? Give feedback.
-
|
I'm still waiting for this feature |
Beta Was this translation helpful? Give feedback.
-
|
How is this still not a thing!!? |
Beta Was this translation helpful? Give feedback.
and others
-
Could the feature for creating pull requests on mobile phones be implemented?
Beta Was this translation helpful? Give feedback.
All reactions