Changing base branch triggers GitHub to dismiss reviews

[kenocrates]

Select Topic Area

Bug

Body

Until recently (as far back as 11 Jan 2023 or as recently as 29 Jan 2023) changing the base branch of a PR did not automatically dismiss previous accepted reviews as stale. Now it does, with the comment "The base branch was changed".

[nhurden]

This seems to break git spr merge, since that relies on changing the base branch to rebase-merge a stack of PRs: https://github.com/ejoffe/spr

[kenocrates]

Not an answer but perhaps this will lean support for reverting the change.

[kenocrates]

I have observed today that the behaviour has reverted.

[edenman]

I'm seeing this. Can't find any setting that seems like it would control this behavior, but maybe it's "Require approval of the most recent reviewable push" and changing the base branch counts as a reviewable push for some reason?