superenv interfering with dependent header for libusb

[phreed]

Output of brew config

HOMEBREW_VERSION: 4.4.17-20-g55475cb
ORIGIN: https://github.com/Homebrew/brew
HEAD: 55475cb11a0ebda03c7a4dce19db52b748cd5db3
Last commit: 9 hours ago
Branch: master
Core tap HEAD: 91b149d1542110c3bd024f234f55cb5d3396b960
Core tap last commit: 3 hours ago
Core tap JSON: 22 Jan 18:44 UTC
HOMEBREW_PREFIX: /home/linuxbrew/.linuxbrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: :0
HOMEBREW_EDITOR: /usr/bin/nano
HOMEBREW_MAKE_JOBS: 22
HOMEBREW_SORBET_RUNTIME: set
SUDO_ASKPASS: /usr/libexec/openssh/gnome-ssh-askpass
Homebrew Ruby: 3.3.7 => /var/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.7/bin/ruby
CPU: 22-core 64-bit alderlake
Clang: N/A
Git: 2.48.1 => /bin/git
Curl: 8.9.1 => /bin/curl
Kernel: Linux 6.11.8-300.fc41.x86_64 x86_64 GNU/Linux
OS: Bluefin (Version: 41.20250119.1 / FROM Fedora Silverblue 41) (Archaeopteryx)
Host glibc: 2.40
/usr/bin/gcc: 14.2.1
/usr/bin/ruby: N/A
glibc: N/A
gcc@11: N/A
gcc: 14.2.0_1
xorg: N/A

Output of brew doctor

Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Some installed kegs have no formulae!
This means they were either deleted or installed manually.
You should find replacements for the following formulae:
  fsarchiver

Warning: You have unlinked kegs in your Cellar.
Leaving kegs unlinked can lead to build-trouble and cause formulae that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  llvm
  clasp-cl
  glib

Warning: You have uncommitted modifications to Homebrew/homebrew-core.
If this is a surprise to you, then you should stash these modifications.
Stashing returns Homebrew to a pristine state but can be undone
should you later need to do so for some reason.
  cd /var/home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core && git stash -u && git clean -d -f

Uncommitted files:
   M .github/autobump.txt
   M Formula/a/abcmidi.rb
   M Formula/a/aws-nuke.rb
   M Formula/a/awscli.rb
   M Formula/c/cargo-binstall.rb
   M Formula/c/cyphernetes.rb
   M Formula/e/eksctl.rb
   M Formula/f/fern-api.rb
   M Formula/f/flyctl.rb
   D Formula/f/fsarchiver.rb
   M Formula/g/glooctl.rb
   M Formula/g/gnu-getopt.rb
   M Formula/g/gptme.rb
   M Formula/j/jackett.rb
   M Formula/l/lefthook.rb
   M Formula/l/llama.cpp.rb
   M Formula/lib/libadwaita.rb
   M Formula/m/meilisearch.rb
   M Formula/m/mesheryctl.rb
   M Formula/n/neosync.rb
   M Formula/o/operator-sdk.rb
   M Formula/p/php-cs-fixer.rb
   M Formula/p/pixi.rb
   M Formula/r/renovate.rb
   M Formula/s/stylelint.rb
   M Formula/t/teleport.rb
   M Formula/t/testkube.rb
   M Formula/t/texmath.rb
   M Formula/u/util-linux.rb
   M Formula/z/zizmor.rb

Warning: Some taps are not on the default git origin branch and may not receive
updates. If this is a surprise to you, check out the default branch with:
  git -C $(brew --repo phreed/custom) checkout

Description of issue

https://github.com/phreed/homebrew-custom/blob/main/Formula/rpiboot.rb

I am working on a formula for rpiboot.
https://github.com/raspberrypi/usbboot?tab=readme-ov-file#macos

It mostly builds but it appears that superenv is stripping away the -I CFLAGS.

brew install --build-from-source ./rpiboot.rb --verbose

There is a secondary issue related to gcc and -isystem vs. -I where #include <libusb.h> is not found with -I.
But, that is another issue.

Contents of /var/home/phreed/.cache/Homebrew/Logs/rpiboot/01.make.cc

gcc-14 called with: -Wall -Wextra -g -o rpiboot main.c bootfiles.c decode_duid.c -I/home/linuxbrew/.linuxbrew/Cellar/libusb/1.0.27/include/libusb-1.0 -L/home/linuxbrew/.linuxbrew/Cellar/libusb/1.0.27/lib -lusb-1.0 -DGIT_VER="d4aa5041" -DPKG_VER="20240422~085300" -DINSTALL_PREFIX="/usr" -L/home/linuxbrew/.linuxbrew/Cellar/libusb/1.0.27/lib -lusb-1.0
superenv removed:  -Wall -Wextra -g -I/home/linuxbrew/.linuxbrew/Cellar/libusb/1.0.27/include/libusb-1.0 -L/home/linuxbrew/.linuxbrew/Cellar/libusb/1.0.27/lib -L/home/linuxbrew/.linuxbrew/Cellar/libusb/1.0.27/lib
superenv added:    -w -O2 -march=native -isystem/home/linuxbrew/.linuxbrew/include -I/home/linuxbrew/.linuxbrew/opt/berkeley-db@5/include -fdebug-prefix-map=/tmp/rpiboot-20250122-677372-g3ab6h=. -L/home/linuxbrew/.linuxbrew/opt/gcc/lib/gcc/14 -L/home/linuxbrew/.linuxbrew/opt/berkeley-db@5/lib -L/home/linuxbrew/.linuxbrew/lib -B/home/linuxbrew/.linuxbrew/opt/glibc/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/Cellar/rpiboot/latest/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/gcc/lib/gcc/current -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/bzip2/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/zlib/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/pcre2/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/python-packaging/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/mpdecimal/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/openssl@3/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/ncurses/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/readline/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/sqlite/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/xz/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/berkeley-db@5/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/expat/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/libedit/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/libffi/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/[email protected]/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/dbus/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/libxcrypt/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/util-linux/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/glib/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/libcap/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/lz4/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/zstd/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/systemd/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/libusb/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/lib -Wl,--dynamic-linker=/home/linuxbrew/.linuxbrew/lib/ld.so
superenv executed: gcc-14 -w -O2 -march=native -o rpiboot main.c bootfiles.c decode_duid.c -lusb-1.0 -DGIT_VER="d4aa5041" -DPKG_VER="20240422~085300" -DINSTALL_PREFIX="/usr" -lusb-1.0 -isystem/home/linuxbrew/.linuxbrew/include -I/home/linuxbrew/.linuxbrew/opt/berkeley-db@5/include -fdebug-prefix-map=/tmp/rpiboot-20250122-677372-g3ab6h=. -L/home/linuxbrew/.linuxbrew/opt/gcc/lib/gcc/14 -L/home/linuxbrew/.linuxbrew/opt/berkeley-db@5/lib -L/home/linuxbrew/.linuxbrew/lib -B/home/linuxbrew/.linuxbrew/opt/glibc/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/Cellar/rpiboot/latest/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/gcc/lib/gcc/current -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/bzip2/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/zlib/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/pcre2/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/python-packaging/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/mpdecimal/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/openssl@3/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/ncurses/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/readline/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/sqlite/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/xz/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/berkeley-db@5/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/expat/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/libedit/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/libffi/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/[email protected]/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/dbus/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/libxcrypt/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/util-linux/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/glib/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/libcap/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/lz4/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/zstd/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/systemd/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/opt/libusb/lib -Wl,-rpath=/home/linuxbrew/.linuxbrew/lib -Wl,--dynamic-linker=/home/linuxbrew/.linuxbrew/lib/ld.so

[phreed]

I did the following to get past the issues:

brew install --build-from-source ./rpiboot.rb --debug

Which produced the following error message:

gcc-14 -Wall -Wextra -g  -o rpiboot main.c bootfiles.c decode_duid.c `pkg-config --cflags --libs libusb-1.0` -DGIT_VER="\"d4aa5041\"" -DPKG_VER="\"20240422~085300\"" -DINSTALL_PREFIX=\"/usr\" -L/home/linuxbrew/.linuxbrew/Cellar/libusb/1.0.27/lib -lusb-1.0
main.c:1:10: fatal error: libusb.h: No such file or directory
    1 | #include <libusb.h>
      |          ^~~~~~~~~~
compilation terminated.

Then from the shell.

pkg-config --cflags --libs libusb-1.0

Which gives:

-I/home/linuxbrew/.linuxbrew/Cellar/libusb/1.0.27/include/libusb-1.0 -L/home/linuxbrew/.linuxbrew/Cellar/libusb/1.0.27/lib -lusb-1.0

Then I run the following corrected compilation:

gcc-14 -Wall -Wextra -g  -o rpiboot main.c bootfiles.c decode_duid.c -isystem/home/linuxbrew/.linuxbrew/Cellar/libusb/1.0.27/include/libusb-1.0 -L/home/linuxbrew/.linuxbrew/Cellar/libusb/1.0.27/lib -lusb-1.0 -DGIT_VER="\"d4aa5041\"" -DPKG_VER="\"20240422~085300\"" -DINSTALL_PREFIX=\"/usr\" -L/home/linuxbrew/.linuxbrew/Cellar/libusb/1.0.27/lib -lusb-1.0

That builds.
Then exit and (2) ignore.

This gives me a valid rpiboot.

[phreed]

Alternatively, if I modify the /var/home/linuxbrew/.linuxbrew/lib/pkgconfig/libusb-1.0.pc
replacing the Cflags: -I... with Cflags: -isystem... the build works as expected.

prefix=/home/linuxbrew/.linuxbrew/Cellar/libusb/1.0.27
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include

Name: libusb-1.0
Description: C API for USB device access from Linux, Mac OS X, Windows, OpenBSD/NetBSD and Solaris userspace
Version: 1.0.27
Libs: -L${libdir} -lusb-1.0
Libs.private: -ludev 
Cflags: -isystem${includedir}/libusb-1.0

My guess is that in this case superenv leaves these includes alone.