Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to burn #3989

Closed
gus4rs opened this issue Oct 8, 2024 · 12 comments
Closed

How to burn #3989

gus4rs opened this issue Oct 8, 2024 · 12 comments

Comments

@gus4rs
Copy link

gus4rs commented Oct 8, 2024

Guess this is more a usability question than a bug.

Trying to burn an inscription with

ord wallet burn  --fee-rate 20 --postage 1sat <inscription id> 

and am being greeted by

error: JSON-RPC error: RPC error response: RpcError { code: -25, message: "Unspendable output exceeds maximum configured by user (maxburnamount)", data: None }

This is a bitcoin core fart preventing sending funds to OP_RETURN. My understanding is this param (maxburnamount) should be passed to sendrawtransaction, so nothing I can do.

Is the burn feature useless then?

@gus4rs
Copy link
Author

gus4rs commented Oct 8, 2024

If I use the same burn command above but with dry-run then copy the psbt, import it in Sparrow and broadcast, it gets confirmed, and apparently it works

@onchainguy-btc
Copy link
Contributor

Damn. I think to make this work we would need to add support for maxburnamount here.

@raphjaph If you want I can have a look at this together with #3977 this week.

@raphjaph
Copy link
Collaborator

raphjaph commented Oct 8, 2024

Ah damn, our mockcore tests strike again. @onchainguy-btc yes that would be great. Best to split these different issues into separate PRs for easier review.

@gus4rs
Copy link
Author

gus4rs commented Oct 8, 2024

Bro, you seriously didn't try to run the burn command even once for real? 😂

When it comes to Core, an outdated spaghetti full of convoluted flags, work arounds, obnoxious API, this is asking for trouble lol

@casey
Copy link
Collaborator

casey commented Oct 8, 2024

lmao gottem

@raphjaph
Copy link
Collaborator

raphjaph commented Oct 8, 2024

ded

@onchainguy-btc
Copy link
Contributor

💀

@gus4rs
Copy link
Author

gus4rs commented Oct 9, 2024

Become a mock disrespectoor

@raphjaph
Copy link
Collaborator

raphjaph commented Oct 9, 2024

I'm starting to become one

@raphjaph raphjaph added this to Tracker Oct 19, 2024
@raphjaph raphjaph moved this to In Progress in Tracker Oct 19, 2024
@onchainguy-btc
Copy link
Contributor

Managed to pass the max burn amount on my local ord setup. Now running into this error:

error: JSON-RPC error: RPC error response: RpcError { code: -26, message: "tx-size-small", data: None }

Seems to be related to this issue. Need to investigate further 🤔

@onchainguy-btc
Copy link
Contributor

Works when I add some random bytes to the OP_RETURN output to increase the tx size. @raphjaph before submitting the burn tx, we could check the tx size and only if too small add some bytes. Or do you have a better idea?

@raphjaph
Copy link
Collaborator

This should now be fixed in #4106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants