Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github action codecov to v4 when fixed #1291

Closed
1 task
TerryHowe opened this issue Mar 15, 2024 · 2 comments · Fixed by #1324
Closed
1 task

Update github action codecov to v4 when fixed #1291

TerryHowe opened this issue Mar 15, 2024 · 2 comments · Fixed by #1324
Labels
dependencies Pull requests that update a dependency file test General testing related issues or pull requests

Comments

@TerryHowe
Copy link
Member

What happened in your environment?

It looks like there are problems with v4 coverage I was not aware off. Reverting for now.

codecov/codecov-action#1292

What did you expect to happen?

it to work

How can we reproduce it?

Run v4 codecov

What is the version of your ORAS CLI?

main/latest

What is your OS environment?

linux

Are you willing to submit PRs to fix it?

  • Yes, I am willing to fix it.
@TerryHowe TerryHowe added bug Something isn't working triage New issues or PRs to be acknowledged by maintainers labels Mar 15, 2024
@TerryHowe TerryHowe mentioned this issue Mar 17, 2024
Merged
@shizhMSFT shizhMSFT added dependencies Pull requests that update a dependency file test General testing related issues or pull requests and removed bug Something isn't working triage New issues or PRs to be acknowledged by maintainers labels Mar 19, 2024
danielfromearth added a commit to nasa/ncompare that referenced this issue Mar 19, 2024
@danielfromearth
revert codecov-action to v3 until v4 fix, following oras-project/oras…
0c708c9 
…#1291
@qweeah qweeah mentioned this issue Apr 7, 2024
Merged
4 tasks
@TerryHowe TerryHowe reopened this Apr 8, 2024
@TerryHowe
Copy link
Member Author

Seems like this isn't fixed.

@TerryHowe TerryHowe mentioned this issue Apr 8, 2024
Closed
@qweeah
Copy link
Contributor

qweeah commented Apr 8, 2024

Dependabot PRs are failing, should replicate codecov token to dependabot secrets as is suggested in codecov/codecov-action#1292 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file test General testing related issues or pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump(ci): update codecov gha to v4 qweeah/oras
3 participants
@TerryHowe @qweeah @shizhMSFT