Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMEDWAIT does not result in timeout before ping probe timeout #330

Open
7opf opened this issue Apr 28, 2024 · 0 comments
Open

TIMEDWAIT does not result in timeout before ping probe timeout #330

7opf opened this issue Apr 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@7opf
Copy link

7opf commented Apr 28, 2024

Yes, this patch will be included in the upcoming release of 2.2. I plan to close this issue after that release has been completed. Thanks for your help in verifying the fix!

Regarding the second issue, the "hang" should not be indefinite as the underlying network will eventually give up and raise an exception. That could, however, be a rather long time! A separate enhancement is needed here -- the addition of pool_ping_timeout with a reasonable default. If you wish to create a separate issue for this additional feature, please go ahead and do so. That will be addressed in the next release.

Originally posted by @anthony-tuininga in #221 (comment)

I would consider this a bug rather than an enhancement, based on this description: https://python-oracledb.readthedocs.io/en/latest/api_manual/module.html#oracledb.POOL_GETMODE_TIMEDWAIT

A caller expects to receive the timeout at wait_timeout, but currently, due to a separate ping timeout, this could be much longer.

@cjbj cjbj added the enhancement New feature or request label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants