Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer from using console related functions(eg: log, warn or error) #128

Open
joeOracle opened this issue Mar 29, 2022 · 1 comment
Open
Labels
SDK Issue pertains to the SDK itself and not specific to any service

Comments

@joeOracle
Copy link

If I may suggest, drop the use of console related logs and add no-console eslint rule to the project. Use the logger that you already have. Make use of debug logging concept not the intrusive way.

One justifiable reason for this is, our implementors usually don't care the details we have in those console.logs/error/warn. If ever they care about it, they can turn on the debugging so that they will see these. Second, which I am currently facing, I am creating a cli prompt for the user, and the known errors like not found bucket distract the user experience.

@jodoglevy jodoglevy added the SDK Issue pertains to the SDK itself and not specific to any service label Apr 1, 2022
@jodoglevy
Copy link
Member

@joeOracle thanks for reporting - we'll investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SDK Issue pertains to the SDK itself and not specific to any service
Projects
None yet
Development

No branches or pull requests

3 participants
@jodoglevy @joeOracle and others