Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for next.config.ts in paraglide cli init command #3199

Conversation

gerardmarquinarubio
Copy link
Contributor

Really silly PR but I think its important taking into account that NextJS 15 init will now by default create next.config.ts files.

inlang/source-code/paraglide/paraglide-next/src/cli/flows/addPluginToNextConfig.ts doesn't need to be modified as it relies purely on regex to modify the NextJs config.

Couldn't test as I can't seem to get a build going on my Ubuntu machine.

Apologies in advance for possibly missing any procedures in my contribution but I couldn't find any guides or references to do so for this repo.

Copy link

changeset-bot bot commented Nov 3, 2024

🦋 Changeset detected

Latest commit: 49b54dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@inlang/paraglide-next Patch
@inlang/paraglide-next-e2e Patch
@inlang/paraglide-next-example-app Patch
@inlang/paraglide-next-example-pages Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 3, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@gerardmarquinarubio
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 3, 2024
@gerardmarquinarubio
Copy link
Contributor Author

I could run the build commands succesfully after downgrading to node 22 evanw/esbuild#3951 .

@samuelstroschein
Copy link
Member

mercy for the PR.

i suspect that nothing will be affected, given that the only change is adding a matching string the the array and CI runs through. will be published as 0.7.3

@samuelstroschein samuelstroschein merged commit 85233be into opral:main Nov 3, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants