Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sherlock Cache Crash #2958

Merged
merged 8 commits into from
Jun 21, 2024
Merged

Sherlock Cache Crash #2958

merged 8 commits into from
Jun 21, 2024

Conversation

LorisSigrist
Copy link
Collaborator

This PR:

  • Fixes Sherlock's FS wrapper to no longer swallow arguments
  • Adds better Errors to the SDK to make locating issues easier
  • Makes sure the SDK no longer errors when it fails to write to the cache

Copy link

changeset-bot bot commented Jun 21, 2024

🦋 Changeset detected

Latest commit: de0b0d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
vs-code-extension Patch
@inlang/sdk Patch
@inlang/badge Patch
@inlang/doc-layout-component Patch
@inlang/editor Patch
@inlang/github-lint-action Patch
@inlang/message-bundle-component Patch
@inlang/rpc Patch
@inlang/settings-component Patch
@inlang/telemetry Patch
@inlang/cross-sell-ninja Patch
@inlang/plugin-i18next Patch
@inlang/plugin-json Patch
@inlang/plugin-m-function-matcher Patch
@inlang/plugin-next-intl Patch
@inlang/plugin-t-function-matcher Patch
@inlang/paraglide-unplugin Patch
@inlang/paraglide-js-e2e Patch
@inlang/paraglide-next-e2e Patch
@inlang/paraglide-rollup Patch
@inlang/paraglide-vite Patch
@inlang/paraglide-webpack Patch
@inlang/paraglide-astro Patch
@inlang/paraglide-sveltekit Patch
@inlang/paraglide-sveltekit-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@felixhaeberle felixhaeberle merged commit 0f2e986 into main Jun 21, 2024
5 checks passed
@felixhaeberle felixhaeberle deleted the sherlock-cache-crash branch June 21, 2024 12:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2024
@felixhaeberle
Copy link
Contributor

This was too much of a YOLO merge and your FS wrapper rewrite broke some internal function mapping.
If I revert it and only adjust the mkdir options argument, the code works again.

Rn, I don't have any specific information as its very hard to follow all the code paths the fs functions are travelling.

@felixhaeberle
Copy link
Contributor

Related #2961

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants